Re: [royale-asjs] branch develop updated: Fixes #87 box-sizing was only being set for the view and not the application

[Harbs <ha...@gmail.com>]

I changed the box model for “Application” in addition to “royale”. This makes sure that popups such as Alert which might be attached to the application outside the view, use border-box instead of content-box.

I think this is correct, but I wanted to make sure that others agree and I did not miss something.

Thoughts?

Harbs

> On Nov 14, 2017, at 10:59 AM, harbs@apache.org wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> harbs pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> 
> 
> The following commit(s) were added to refs/heads/develop by this push:
>     new 21cbd13  Fixes #87 box-sizing was only being set for the view and not the application
> 21cbd13 is described below
> 
> commit 21cbd13ddefc4fb8511a21167a30262f5e245086
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Tue Nov 14 10:59:42 2017 +0200
> 
>    Fixes #87
>    box-sizing was only being set for the view and not the application
> ---
> frameworks/projects/Basic/src/main/resources/defaults.css               | 2 +-
> .../projects/Basic/src/main/royale/org/apache/royale/html/Alert.as      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/frameworks/projects/Basic/src/main/resources/defaults.css b/frameworks/projects/Basic/src/main/resources/defaults.css
> index 149bbd4..13f8930 100644
> --- a/frameworks/projects/Basic/src/main/resources/defaults.css
> +++ b/frameworks/projects/Basic/src/main/resources/defaults.css
> @@ -28,7 +28,7 @@
> 	border-width: 1px;
> }
> 
> -.royale *, . royale *:before, . royale *:after {
> +.Application *, .royale *, . royale *:before, . royale *:after {
> 	-moz-box-sizing: border-box;
> 	-webkit-box-sizing: border-box;
> 	box-sizing: border-box;
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as
> index a3857cb..90249d2 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Alert.as
> @@ -148,7 +148,7 @@ package org.apache.royale.html
>             // add a place for the buttons
>             buttonArea = new Container();
>             buttonArea.percentWidth = 100;
> -            buttonArea.height = 28;
> +            buttonArea.height = 30;
>             addElement(buttonArea);
>             buttonArea.element.style.marginTop = "6px";
>             buttonArea.element.style.marginBottom = "6px";
> 
> -- 
> To stop receiving notification emails like this one, please contact
> ['"commits@royale.apache.org" <co...@royale.apache.org>'].