[jira] [Commented] (GROOVY-8471) Contents of META-INF/services/org.codehaus.groovy.source.Extensions conflict with Maven/Jisaw

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363433#comment-16363433 ] 

ASF GitHub Bot commented on GROOVY-8471:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/663

    GROOVY-8471: Contents of META-INF/services/org.codehaus.groovy.source…

    ….Extensions conflict with Maven/Jisaw

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8471

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #663
    
----
commit 613dd488f9c07d367ef1a3d14f2f5aba82e805be
Author: paulk <pa...@...>
Date:   2018-02-14T03:16:22Z

    GROOVY-8471: Contents of META-INF/services/org.codehaus.groovy.source.Extensions conflict with Maven/Jisaw

----


> Contents of META-INF/services/org.codehaus.groovy.source.Extensions conflict with Maven/Jisaw
> ---------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-8471
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8471
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha-1, 2.4.13
>            Reporter: Ceki Gülcü
>            Priority: Critical
>
> From what [I can gather|http://markmail.org/thread/nekeppbvwrfl7hbb#query:+page:1+mid:qtqqcfrw6us6aupz+state:results], Jigsaw module resolution analyzes the contents of module-info.class, MANIFEST.MF and META-INF/services/* files. 
> As such, it turns out that the contents of {{src/resources/META-INF/services/org.codehaus.groovy.source.Extensions}} prevents groovy-*.jar from being loaded as an automatic module, at least within a Maven build.
> [~rfscholte] has pointed out that this is not a Maven specific problem as can be verified in JShell by invoking: 
> {code}
> java.lang.module.ModuleFinder.of(java.nio.file.Paths.get(artifact)).findAll().stream().findFirst().get().descriptor().name()
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)