You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/02/22 20:08:44 UTC

[jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort

    [ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879127#comment-15879127 ] 

stack commented on HBASE-17677:
-------------------------------

+1

Thanks [~busbey] Good test.

> ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17677
>                 URL: https://issues.apache.org/jira/browse/HBASE-17677
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17677.1.patch
>
>
> our internal Address facade over HostAndPort directly passes on any failures from the underlying Guava implementation. Right now when we parse a ServerName from a WAL directory we properly handle if guava gives us an IllegalArgumentException but we do not handle if it gives us a IllegalStateException. e.g. it uses the former for "I couldn't parse anything out of this string" and the latter for "I parsed a host name but didn't see a port".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)