You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/07/01 11:55:41 UTC

[GitHub] commons-lang pull request #274: Fix ExceptionUtils#getStackFrame(String) jav...

GitHub user mureinik opened a pull request:

    https://github.com/apache/commons-lang/pull/274

    Fix ExceptionUtils#getStackFrame(String) javadoc

    `ExceptionUtils#getStackFrame(String)`'s javadoc contains a broken reference to `SystemUtils#LINE_SEPARATOR` (as the class name is not fully qualified, and there's no import of `org.apache.commons.lang3.SystemUtils`).
    
    This patch fixes the broken reference by replacing it it with a reference to `System#lineSeparator()`, which the method actually uses.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mureinik/commons-lang lineseparator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #274
    
----
commit 564bd25adc51d29f991545395a5e53e0c96e3171
Author: Allon Mureinik <am...@redhat.com>
Date:   2017-07-01T11:50:41Z

    Fix ExceptionUtils#getStackFrame(String) javadoc
    
    ExceptionUtils#getStackFrame(String)'s javadoc contains a broken
    reference to SystemUtils#LINE_SEPARATOR (as the class name is not
    fully qualified, and there's no import of
    org.apache.commons.lang3.SystemUtils).
    
    This patch fixes the broken reference by replacing it it with a
    reference to System#lineSeparator(), which the method actually uses.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #274: Fix ExceptionUtils#getStackFrame(String) javadoc

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/274
  
    
    [![Coverage Status](https://coveralls.io/builds/12217152/badge)](https://coveralls.io/builds/12217152)
    
    Coverage increased (+0.05%) to 95.219% when pulling **564bd25adc51d29f991545395a5e53e0c96e3171 on mureinik:lineseparator** into **5f0d8127579c1ce73f21daa509271c14af78b143 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #274: Fix ExceptionUtils#getStackFrame(String) jav...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/274


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #274: Fix ExceptionUtils#getStackFrame(String) javadoc

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/274
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---