You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/31 05:38:34 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
jorgecarleitao opened a new pull request #9378:
URL: https://github.com/apache/arrow/pull/9378
This is a small refactor that exposes the functions used to convert dates and times into `NaiveDate`, `NaiveTime` and `NaiveDateTime`. They are currently hidden beind the `PrimitiveArray<ArrowTemporalType>::value_as_time`, which makes them difficult to use when the transformation is to be applied in SIMD, or when we want to reproduce the operation for a single scalar value (not in an arrow array).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9378:
URL: https://github.com/apache/arrow/pull/9378#issuecomment-770330650
https://issues.apache.org/jira/browse/ARROW-11442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9378:
URL: https://github.com/apache/arrow/pull/9378#issuecomment-770345217
This looks good 👍! This would also be helpful for removing some indirection in the temporal kernels. Maybe the module name could be called `temporal_conversions` or `datetime_conversions`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9378:
URL: https://github.com/apache/arrow/pull/9378#issuecomment-770332463
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=h1) Report
> Merging [#9378](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=desc) (16ae9fe) into [master](https://codecov.io/gh/apache/arrow/commit/f05b49bb08c0a4cc0cbfcfb07103dcf374c7fd38?el=desc) (f05b49b) will **increase** coverage by `0.00%`.
> The diff coverage is `97.50%`.
[](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9378 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 231 232 +1
Lines 53374 53385 +11
=======================================
+ Hits 43739 43749 +10
- Misses 9635 9636 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `94.74% <91.66%> (-0.21%)` | :arrow_down: |
| [rust/arrow/src/conversions.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29udmVyc2lvbnMucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=footer). Last update [f05b49b...16ae9fe](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9378:
URL: https://github.com/apache/arrow/pull/9378#issuecomment-771183326
I think this is small enough / not backwards breaking to merge. So doing so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9378:
URL: https://github.com/apache/arrow/pull/9378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9378: ARROW-11442: [Rust] Expose datetime conversion logic independently
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9378:
URL: https://github.com/apache/arrow/pull/9378#issuecomment-770332463
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=h1) Report
> Merging [#9378](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=desc) (6310c6d) into [master](https://codecov.io/gh/apache/arrow/commit/f05b49bb08c0a4cc0cbfcfb07103dcf374c7fd38?el=desc) (f05b49b) will **increase** coverage by `0.01%`.
> The diff coverage is `97.50%`.
[](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9378 +/- ##
==========================================
+ Coverage 81.94% 81.96% +0.01%
==========================================
Files 231 231
Lines 53374 53372 -2
==========================================
+ Hits 43739 43748 +9
+ Misses 9635 9624 -11
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `94.74% <91.66%> (-0.21%)` | :arrow_down: |
| [rust/arrow/src/temporal\_conversions.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdGVtcG9yYWxfY29udmVyc2lvbnMucnM=) | `100.00% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `83.52% <0.00%> (-0.15%)` | :arrow_down: |
| [rust/datafusion/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `88.20% <0.00%> (-0.07%)` | :arrow_down: |
| [rust/datafusion/src/optimizer/optimizer.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvb3B0aW1pemVyLnJz) | | |
| [rust/datafusion/src/sql/planner.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvcGxhbm5lci5ycw==) | `84.17% <0.00%> (+0.01%)` | :arrow_up: |
| [rust/datafusion/src/physical\_plan/planner.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BsYW5uZXIucnM=) | `78.78% <0.00%> (+0.14%)` | :arrow_up: |
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `89.21% <0.00%> (+0.49%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/arrow/pull/9378/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=footer). Last update [f05b49b...421ee98](https://codecov.io/gh/apache/arrow/pull/9378?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org