You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/03/18 13:43:04 UTC

[GitHub] [buildstream] abderrahim opened a new issue #1459: buildstream stages files from tar files with wrong permissions

abderrahim opened a new issue #1459:
URL: https://github.com/apache/buildstream/issues/1459


   Trying to build qemu ([tarball](https://download.qemu.org/qemu-5.2.0.tar.xz)), I noticed that buildstream stages some files as executable even though they shouldn't be. For instance
   ```python
   >>> import tarfile
   >>> tar = tarfile.open('qemu-5.2.0.tar.xz')
   >>> tar.getmember('qemu-5.2.0/pc-bios/hppa-firmware.img').get_info()
   {'name': 'qemu-5.2.0/pc-bios/hppa-firmware.img', 'mode': 436, 'uid': 1000, 'gid': 1000, 'size': 785696, 'mtime': 1607446784, 'chksum': 7844, 'type': b'0', 'linkname': '', 'uname': 'fluxion', 'gname': 'fluxion', 'devmajor': 0, 'devminor': 0}
   ```
   where 436 is 664 in octal. However in the sandbox
   ```bash
   $ ls -l pc-bios/hppa-firmware.img 
   -rwxr-xr-x 1 abderrahim abderrahim 785696 Nov 11  2011 pc-bios/hppa-firmware.img
   ```
   that is 755.
   
   I see the tar plugin does some [funny stuff with the permissions](https://github.com/apache/buildstream/blob/master/src/buildstream/plugins/sources/tar.py#L67), the error certainly lies in there.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] gtristan closed issue #1459: buildstream stages files from tar files with wrong permissions

Posted by GitBox <gi...@apache.org>.
gtristan closed issue #1459:
URL: https://github.com/apache/buildstream/issues/1459


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org