You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/30 18:50:21 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2627: OS internal function should indicate the error by return negative value

xiaoxiang781216 opened a new pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627


   ## Summary
   instead to change errno value by calling set_errno
   
   ## Impact
   No function change.
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#issuecomment-752796689


   We have #2629 for that issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#issuecomment-752751238


   BTW the checks are failing because of #2618.  The following should fix the issue but I don't know if there is a better solution.
   
   ```diff
   diff --git a/fs/vfs/fs_unlink.c b/fs/vfs/fs_unlink.c
   index 5b0b6053f7..490fcd0059 100644
   --- a/fs/vfs/fs_unlink.c
   +++ b/fs/vfs/fs_unlink.c
   @@ -191,8 +191,10 @@ int nx_unlink(FAR const char *pathname)
      RELEASE_SEARCH(&desc);
      return OK;
   
   +#ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS
    errout_with_sem:
      inode_semgive();
   +#endif
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#discussion_r550300785



##########
File path: drivers/sensors/adxl372.c
##########
@@ -716,10 +720,12 @@ static void adxl372_dvr_exchange(FAR void *instance_handle,
                                  FAR const void *txbuffer,
                                  FAR void *rxbuffer, size_t nwords)
 {
-  FAR struct adxl372_dev_s *priv = (FAR struct adxl372_dev_s *)instance_handle;
+  FAR struct adxl372_dev_s *priv = instance_handle;

Review comment:
       Why is the implicit cast removed here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#issuecomment-752829828


   > We have #2629 for that issue.
   
   Thanks, I will rebase to the latest mainline.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#discussion_r550388212



##########
File path: drivers/sensors/adxl372.c
##########
@@ -716,10 +720,12 @@ static void adxl372_dvr_exchange(FAR void *instance_handle,
                                  FAR const void *txbuffer,
                                  FAR void *rxbuffer, size_t nwords)
 {
-  FAR struct adxl372_dev_s *priv = (FAR struct adxl372_dev_s *)instance_handle;
+  FAR struct adxl372_dev_s *priv = instance_handle;

Review comment:
       @Ouss4 I short instance_handle to instance, please review again.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2627: OS internal function should indicate the error by return negative value

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2627:
URL: https://github.com/apache/incubator-nuttx/pull/2627#discussion_r550386134



##########
File path: drivers/sensors/adxl372.c
##########
@@ -716,10 +720,12 @@ static void adxl372_dvr_exchange(FAR void *instance_handle,
                                  FAR const void *txbuffer,
                                  FAR void *rxbuffer, size_t nwords)
 {
-  FAR struct adxl372_dev_s *priv = (FAR struct adxl372_dev_s *)instance_handle;
+  FAR struct adxl372_dev_s *priv = instance_handle;

Review comment:
       To fix the long length warning.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org