[GitHub] [cordova-plugin-network-information] PieterVanPoyer edited a comment on pull request #114: Android - Fixes https://github.com/apache/cordova-plugin-network-information#110

[GitBox <gi...@apache.org>]

PieterVanPoyer edited a comment on pull request #114:
URL: https://github.com/apache/cordova-plugin-network-information/pull/114#issuecomment-646252009


   > It would also be nice if you could bring all the else/else if statement of `getType` to the same line as the bracket.
   
   I am not entirely sure about your remark. But I did improve it a little bit.
   
   Or do you mean changing  this
   ```
   } else if (type.startsWith(CDMA) ||
                       type.equals(UMTS) ||
                       type.equals(ONEXRTT) ||
                       type.equals(EHRPD) ||
                       type.equals(HSUPA) ||
                       type.equals(HSDPA) ||
                       type.equals(HSPA) ||
                       type.equals(THREE_G)) {
                   return TYPE_3G;
               }
   ```
   to something like this?
   ```
   } else if (type.startsWith(CDMA) || type.equals(UMTS) || type.equals(ONEXRTT) || type.equals(EHRPD) || type.equals(HSUPA) || type.equals(HSDPA) || type.equals(HSPA) || type.equals(THREE_G)) {
       return TYPE_3G; 
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org