[GitHub] [ozone] adoroszlai commented on a change in pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#discussion_r746512174



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java
##########
@@ -53,8 +53,8 @@
 
   enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
 
-  @Option(names = { "--type", "-t" },
-      description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+  @Option(names = { "--bucketlayout", "-l" },

Review comment:
       Can we simplify `bucketlayout` to `layout`?  The command name `... bucket create` implies the layout is for the bucket.
   
   Also, should we keep `--type`, `-t` as alias for compatibility?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org