[impala] branch master updated: IMPALA-11614: Fix test_metrics_are_zero for Ozone

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 12059ba14 IMPALA-11614: Fix test_metrics_are_zero for Ozone
12059ba14 is described below

commit 12059ba145ccab40be3befde59bd5b71a9f76aea
Author: Michael Smith <mi...@cloudera.com>
AuthorDate: Mon Sep 26 12:26:21 2022 -0700

    IMPALA-11614: Fix test_metrics_are_zero for Ozone
    
    Fixes TestValidateMetrics.test_metrics_are_zero failure and avoids
    incrementing the `num-missing-volume-id` metric for Ozone paths because
    Ozone currently returns a list of nulls representing volume IDs.
    Therefore the metric does not provide useful feedback with Ozone.
    
    Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
    Reviewed-on: http://gerrit.cloudera.org:8080/19044
    Reviewed-by: Joe McDonnell <jo...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/exec/hdfs-scan-node-base.cc | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/be/src/exec/hdfs-scan-node-base.cc b/be/src/exec/hdfs-scan-node-base.cc
index 6ecc17dd6..02c306cb2 100644
--- a/be/src/exec/hdfs-scan-node-base.cc
+++ b/be/src/exec/hdfs-scan-node-base.cc
@@ -309,7 +309,14 @@ Status HdfsScanPlanNode::ProcessScanRangesAndInitSharedState(FragmentState* stat
       }
 
       bool expected_local = params.has_is_remote() && !params.is_remote();
-      if (expected_local && params.volume_id() == -1) ++num_ranges_missing_volume_id;
+      if (expected_local && params.volume_id() == -1) {
+        // IMPALA-11541 TODO: Ozone returns a list of null volume IDs. So we know the
+        // number of volumes, but ID will be -1. Skip this metric for Ozone paths because
+        // it doesn't convey useful feedback.
+        if (!IsOzonePath(partition_desc->location().c_str())) {
+          ++num_ranges_missing_volume_id;
+        }
+      }
 
       int cache_options = BufferOpts::NO_CACHING;
       if (params.has_try_hdfs_cache() && params.try_hdfs_cache()) {