You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ga...@apache.org on 2022/10/26 15:35:00 UTC

[incubator-seatunnel] branch dev updated: [Bug][CI] Fix ut error when only e2e code update (#3196)

This is an automated email from the ASF dual-hosted git repository.

gaojun2048 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 8288ca991 [Bug][CI] Fix ut error when only e2e code update (#3196)
8288ca991 is described below

commit 8288ca9915ee6729fb2fe5ce4a64343c64b6f735
Author: Eric <ga...@gmail.com>
AuthorDate: Wed Oct 26 23:34:55 2022 +0800

    [Bug][CI] Fix ut error when only e2e code update (#3196)
    
    * fix ut error when only e2e code update
---
 .github/workflows/backend.yml | 133 +-----------------------------------------
 1 file changed, 1 insertion(+), 132 deletions(-)

diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index db37f633f..a92a2eea2 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -237,137 +237,6 @@ jobs:
       - name: Check Dependencies Licenses
         run: tools/dependencies/checkLicense.sh
 
-  changes:
-    runs-on: ubuntu-latest
-    # To prevent error when there's no base branch
-    if: github.repository == 'apache/incubator-seatunnel'
-    timeout-minutes: 10
-    outputs:
-      api: ${{ steps.filter.outputs.api }}
-      ut-modules: ${{ steps.ut-modules.outputs.modules }}
-      it-modules: ${{ steps.it-modules.outputs.modules }}
-    steps:
-      - uses: actions/checkout@v3 # required for push event
-      - uses: actions/setup-python@v4
-        with:
-          python-version: '2.7'
-      - name: Check for file changes
-        uses: dorny/paths-filter@v2
-        id: filter
-        with:
-          token: ${{ github.token }}
-          list-files: json
-          # The following is a single composite pattern that allows next CI steps,
-          # the pattern is in form of [not (foo or bar)] to be safe.
-          # When new files come in, the CI will NOT ignore them unless listed,
-          # so remember to extend here if they do not serve functional purposes.
-          # NOTE: careful with using ** in expression, keep !**/{old, new things}.
-          filters: |
-            cv2:
-              - "seatunnel-connectors-v2/**"
-            cv2-flink-e2e:
-              - "seatunnel-e2e/seatunnel-flink-connector-v2-e2e/**"
-            cv2-spark-e2e:
-              - "seatunnel-e2e/seatunnel-spark-connector-v2-e2e/**"
-            cv2-e2e:
-              - "seatunnel-e2e/seatunnel-connector-v2-e2e/**"
-            api:
-              - "seatunnel-api"
-              - "seatunnel-apis"
-              - "seatunnel-common"
-              - "seatunnel-config"
-              - "seatunnel-connectors"
-              - "seatunnel-core"
-              - "seatunnel-dist"
-              - "seatunnel-e2e/seatunnel-e2e-common"
-              - "seatunnel-formats"
-              - "seatunnel-plugin-discovery"
-              - "seatunnel-transforms"
-              - "seatunnel-translation"
-              - "seatunnel-e2e/seatunnel-flink-e2e"
-              - "seatunnel-e2e/seatunnel-spark-e2e"
-              - "seatunnel-connectors"
-              - "plugin-mapping.properties"
-              - "**/tools/**"
-              - "pom.xml"
-              - "**/workflows/**"
-            engine:
-              - "seatunnel-engine"
-            engine-e2e:
-              - "seatunnel-e2e/seatunnel-engine-e2e"
-
-      - name: Check Connector V2 Update
-        id: cv2-modules
-        if: ${{ steps.filter.outputs.cv2 == 'true' }}
-        run: |
-          update_files='${{ steps.filter.outputs.cv2_files }}'
-          modules=`python tools/update_modules_check/update_modules_check.py cv2 $update_files`
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-
-      - name: Check Flink Connector V2 E2E Update
-        id: cv2-flink-e2e-modules
-        if: ${{ steps.filter.outputs.cv2-flink-e2e == 'true' }}
-        run: |
-          update_files='${{ steps.filter.outputs.cv2-flink-e2e_files }}'
-          modules=`python tools/update_modules_check/update_modules_check.py cv2-flink-e2e $update_files`
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-          
-      - name: Check Spark Connector V2 E2E Update
-        id: cv2-spark-e2e-modules
-        if: ${{ steps.filter.outputs.cv2-spark-e2e == 'true' }}
-        run: |
-          update_files='${{ steps.filter.outputs.cv2-spark-e2e_files }}'
-          modules=`python tools/update_modules_check/update_modules_check.py cv2-spark-e2e $update_files`
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-          
-      - name: Check Connector V2 E2E Update
-        id: cv2-e2e-modules
-        if: ${{ steps.filter.outputs.cv2-e2e == 'true' }}
-        run: |
-          update_files='${{ steps.filter.outputs.cv2-e2e_files }}'
-          modules=`python tools/update_modules_check/update_modules_check.py cv2-e2e $update_files`
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-
-      - name: Check Engine Update
-        id: engine-modules
-        if: ${{ steps.filter.outputs.engine == 'true' }}
-        run: |
-          update_files='${{ steps.filter.outputs.engine_files }}'
-          modules=`python tools/update_modules_check/update_modules_check.py engine $update_files`
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-          
-      - name: Check Engine E2E Update
-        id: engine-e2e-modules
-        if: ${{ steps.filter.outputs.engine-e2e == 'true' }}
-        run: |
-          update_files='${{ steps.filter.outputs.engine-e2e_files }}'
-          modules=`python tools/update_modules_check/update_modules_check.py engine-e2e $update_files`
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-
-      - name: Make unit test modules
-        id: ut-modules
-        if: ${{ steps.filter.outputs.api == 'false' }}
-        run: |
-          modules='${{ steps.engine-modules.outputs.modules }}${{ steps.cv2-modules.outputs.modules }}'
-          modules=${modules: 1}
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-
-      - name: Make integration test modules
-        id: it-modules
-        if: ${{ steps.filter.outputs.api == 'false' }}
-        run: |
-          modules='${{ steps.cv2-e2e-modules.outputs.modules }}${{ steps.cv2-flink-e2e-modules.outputs.modules }}${{ steps.cv2-spark-e2e-modules.outputs.modules }}${{ steps.engine-e2e-modules.outputs.modules }}${{ steps.engine-modules.outputs.modules }}${{ steps.cv2-modules.outputs.modules }}'
-          modules=${modules: 1}
-          echo $modules
-          echo "modules=$modules" >> $GITHUB_OUTPUT
-
   unit-test:
     needs: [ changes, sanity-check ]
     runs-on: ${{ matrix.os }}
@@ -392,7 +261,7 @@ jobs:
           MAVEN_OPTS: -Xmx2048m
 
       - name: run updated modules unit test
-        if: needs.changes.outputs.api == 'false'
+        if: needs.changes.outputs.api == 'false' && needs.changes.outputs.ut-modules != ""
         run: |
           ./mvnw -B -T 1C clean verify -D"maven.test.skip"=false -D"checkstyle.skip"=true -D"scalastyle.skip"=true -D"license.skipAddThirdParty"=true --no-snapshot-updates -pl ${{needs.changes.outputs.ut-modules}} -am -amd -Pno_dist
         env: