You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/04/26 23:09:54 UTC
[GitHub] wtrocki opened a new pull request #268: CB-14048: (android)
allowedSchemes check empty string fix
wtrocki opened a new pull request #268: CB-14048: (android) allowedSchemes check empty string fix
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/268
## Motivation
The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if AllowSchemes contains empty string after having being loaded, respectively only if null, which could lead to error in case a custom scheme is use but not set as white listed schema
What I mean is that, if no preference would be set in config.xml but a custom scheme would be used (my case) then the variable allowSchemes won't be null but will contains an empty string
Fix for https://issues.apache.org/jira/browse/CB-14048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org