You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Ate Douma (JIRA)" <ji...@apache.org> on 2011/08/10 17:39:27 UTC

[jira] [Created] (RAVE-168) LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts

LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts
--------------------------------------------------------------------------------------------

                 Key: RAVE-168
                 URL: https://issues.apache.org/jira/browse/RAVE-168
             Project: Rave
          Issue Type: Bug
            Reporter: Ate Douma
            Assignee: Ate Douma
            Priority: Blocker
             Fix For: 0.3-INCUBATING


Through the configured maven sources and javadoc plugins -sources and -javadoc artifacts are automatically generated and attached to the build (meaning: they'll get deployed), which is good and great.
However the default configuration/behavior of these plugins won't incorporate (all) the required LICENSE/NOTICE/DISCLAIMER files, which are needed by the ASF legal policy.
This needs to be fixed before the next release can or should be done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (RAVE-168) LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts

Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RAVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085124#comment-13085124 ] 

Ate Douma commented on RAVE-168:
--------------------------------

The problem turned out to be caused by the override of the maven-remote-resources outputDirectory as configured for both the rave-shindig and rave-portal modules.
This override was initially added to ensure the legal files would be included in the build artifact under /META-INF as is expected for war artifacts.
However, the -javadoc and -sources plugins are not aware of this, and therefore the automatically artifacts they produce (during releases) won't have the needed legal files.

I was able to "fix" this going the other way around it: keep processing the maven-remote-resources in the default location (causing the legal files ending up under /WEB-INF/classes/META-INF), but adjusting the maven-war-plugin to also include (copy) these files under /META-INF.
And, to prevent confusion, in particular in case of war overlays (rave-shindig), I'll exclude these files under /WEB-INF/classes/META-INF from packaging in the final war artifact.
By putting the above changes in the rave-master-pom, this then becomes the default and needs no other overrides/customization anymore on child modules, meaning rave-portal and rave-shindig no longer need these. 

> LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts
> --------------------------------------------------------------------------------------------
>
>                 Key: RAVE-168
>                 URL: https://issues.apache.org/jira/browse/RAVE-168
>             Project: Rave
>          Issue Type: Bug
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 0.3-INCUBATING
>
>
> Through the configured maven sources and javadoc plugins -sources and -javadoc artifacts are automatically generated and attached to the build (meaning: they'll get deployed), which is good and great.
> However the default configuration/behavior of these plugins won't incorporate (all) the required LICENSE/NOTICE/DISCLAIMER files, which are needed by the ASF legal policy.
> This needs to be fixed before the next release can or should be done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (RAVE-168) LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts

Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma updated RAVE-168:
---------------------------

    Priority: Major  (was: Blocker)

> LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts
> --------------------------------------------------------------------------------------------
>
>                 Key: RAVE-168
>                 URL: https://issues.apache.org/jira/browse/RAVE-168
>             Project: Rave
>          Issue Type: Bug
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 0.3-INCUBATING
>
>
> Through the configured maven sources and javadoc plugins -sources and -javadoc artifacts are automatically generated and attached to the build (meaning: they'll get deployed), which is good and great.
> However the default configuration/behavior of these plugins won't incorporate (all) the required LICENSE/NOTICE/DISCLAIMER files, which are needed by the ASF legal policy.
> This needs to be fixed before the next release can or should be done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (RAVE-168) LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts

Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma resolved RAVE-168.
----------------------------

    Resolution: Fixed

Fixed.
Note: depends on latest rave-master-pom (0.2-incubating-SNAPSHOT) changes, which also has been deployed again to the SNAPSHOT repository.

> LICENSE/NOTICE/DISCLAIMER files missing from Maven generated -sources and -javadoc artifacts
> --------------------------------------------------------------------------------------------
>
>                 Key: RAVE-168
>                 URL: https://issues.apache.org/jira/browse/RAVE-168
>             Project: Rave
>          Issue Type: Bug
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 0.3-INCUBATING
>
>
> Through the configured maven sources and javadoc plugins -sources and -javadoc artifacts are automatically generated and attached to the build (meaning: they'll get deployed), which is good and great.
> However the default configuration/behavior of these plugins won't incorporate (all) the required LICENSE/NOTICE/DISCLAIMER files, which are needed by the ASF legal policy.
> This needs to be fixed before the next release can or should be done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira