You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by brightchen <gi...@git.apache.org> on 2016/06/15 23:49:26 UTC
[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...
GitHub user brightchen opened a pull request:
https://github.com/apache/apex-malhar/pull/320
APEXMALHAR-2120 #resolve #comment solve problems of KafkaInputOperato\u2026
\u2026rTest and AbstractKafkaInputOperator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brightchen/apex-malhar APEXMALHAR-2120
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #320
----
commit 7055fa2ddcd931b18e75bbb96b6e97f24f1f5889
Author: brightchen <br...@datatorrent.com>
Date: 2016-06-14T23:30:17Z
APEXMALHAR-2120 #resolve #comment solve problems of KafkaInputOperatorTest and AbstractKafkaInputOperator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...
Posted by amberarrow <gi...@git.apache.org>.
Github user amberarrow commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/320#discussion_r67269717
--- Diff: kafka/src/test/java/org/apache/apex/malhar/kafka/KafkaInputOperatorTest.java ---
@@ -120,8 +127,14 @@ public KafkaInputOperatorTest(boolean hasMultiCluster, boolean hasMultiPartition
*/
public static class CollectorModule extends BaseOperator
{
-
- public final transient CollectorInputPort inputPort = new CollectorInputPort(this);
+ public final transient DefaultInputPort<byte[]> inputPort = new DefaultInputPort<byte[]>()
+ {
--- End diff --
indentation is odd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...
Posted by brightchen <gi...@git.apache.org>.
GitHub user brightchen reopened a pull request:
https://github.com/apache/apex-malhar/pull/320
APEXMALHAR-2120 #resolve #comment solve problems of KafkaInputOperato\u2026
\u2026rTest and AbstractKafkaInputOperator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brightchen/apex-malhar APEXMALHAR-2120
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #320
----
commit 6f99fb20da7214f493b442ce4ba3f447ec51cd13
Author: brightchen <br...@datatorrent.com>
Date: 2016-06-14T23:30:17Z
APEXMALHAR-2120 #resolve #comment solve problems of KafkaInputOperatorTest and AbstractKafkaInputOperator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen closed the pull request at:
https://github.com/apache/apex-malhar/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...
Posted by siyuanh <gi...@git.apache.org>.
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/320#discussion_r67769627
--- Diff: kafka/pom.xml ---
@@ -198,7 +198,7 @@
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka_2.11</artifactId>
- <version>0.9.0.0</version>
+ <version>0.9.0.1</version>
--- End diff --
Why this version change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen closed the pull request at:
https://github.com/apache/apex-malhar/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---