You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2024/11/27 05:39:59 UTC

[PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

peterxcli opened a new pull request, #17955:
URL: https://github.com/apache/kafka/pull/17955

   In kraft the [replicas algorithm](https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/metadata/placement/StripedReplicaPlacer.java#L156) includes some randomization, so we should not deterministic assert
   
   testing:
   1. For testReplicaPlacementAllServers:
       - Each partition should have exactly 4 replicas
       - All replicas should be chosen from brokers 0-3
       - Each partition should have a leader
       - The leader should be one of the replicas
   2. For testReplicaPlacementPartialServers:
       - Each partition should have exactly 2 replicas
       - All replicas should be chosen from brokers 0-3
       - Each partition should have a leader
       - The leader should be one of the replicas
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17955:
URL: https://github.com/apache/kafka/pull/17955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on code in PR #17955:
URL: https://github.com/apache/kafka/pull/17955#discussion_r1860984674


##########
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##########
@@ -17,14 +17,13 @@
 
 package kafka.admin
 
-import java.util.{Collections, Optional}
+import java.util.{Collections}

Review Comment:
   -> import java.util.Collections



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on code in PR #17955:
URL: https://github.com/apache/kafka/pull/17955#discussion_r1861038757


##########
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##########
@@ -17,14 +17,13 @@
 
 package kafka.admin
 
-import java.util.{Collections, Optional}
+import java.util.{Collections}

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org