You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/08 23:27:03 UTC
[GitHub] [couchdb-erlfdb] kocolosk opened a new issue #38: Fully support FDB API version 630
kocolosk opened a new issue #38:
URL: https://github.com/apache/couchdb-erlfdb/issues/38
It seems there are a handful of changes in API version 630 that we ought to be accounting for:
https://apple.github.io/foundationdb/api-version-upgrade-guide.html#api-version-630
Specifically:
* The `get_addresses_for_key` function now returns strings that include the port in the address. Prior to API version 630, this required using the `INCLUDE_PORT_IN_ADDRESS` option, which has now been deprecated.
* The `ENABLE_SLOW_TASK_PROFILING` network option has been replaced by `ENABLE_RUN_LOOP_PROFILING` and is now deprecated.
* The `FDBKeyValue` struct’s `key` and `value` members have changed type from `void*` to `uint8_t*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on issue #38: Fully support FDB API version 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on issue #38:
URL: https://github.com/apache/couchdb-erlfdb/issues/38#issuecomment-964296906
Turns out we also need to support `get_estimated_range_size`: https://github.com/apple/foundationdb/commit/69b572cc8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk closed issue #38: Fully support FDB API version 630
Posted by GitBox <gi...@apache.org>.
kocolosk closed issue #38:
URL: https://github.com/apache/couchdb-erlfdb/issues/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk closed issue #38: Fully support FDB API version 630
Posted by GitBox <gi...@apache.org>.
kocolosk closed issue #38:
URL: https://github.com/apache/couchdb-erlfdb/issues/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on issue #38: Fully support FDB API version 630
Posted by GitBox <gi...@apache.org>.
kocolosk commented on issue #38:
URL: https://github.com/apache/couchdb-erlfdb/issues/38#issuecomment-963727243
As far as I can tell only the `ENABLE_RUN_LOOP_PROFILING` option requires any actual code changes; that's now been added in 0f3bee4. We ought to have a better story for warning about the use of deprecated options, but they're not causing any harm at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org