You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by thammegowda <gi...@git.apache.org> on 2016/05/16 21:41:48 UTC
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
GitHub user thammegowda opened a pull request:
https://github.com/apache/incubator-joshua/pull/13
JOSHUA-264 System.exit() calls are replaced by throw new RuntimeException()
This PR replaces system exit calls with runtime exception
+ The error messages are preserved by passing them as message argument
+ the redundant catch blocks are replaced with compact catch blocks
+ The cause for exceptions are propagated to RuntimeException's cause where applicable
Note :
+ Some exit calls from main function are left untouched since they are most likely be invoked from CLI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thammegowda/incubator-joshua JOSHUA-264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 9848541f6cf52e7d316d1bacc565004c1bbc3128
Author: Thamme Gowda <tg...@gmail.com>
Date: 2016-05-16T21:33:29Z
System.exit() removed and replaced with RuntimeException(...)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by KellenSunderland <gi...@git.apache.org>.
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-220772283
Hey Thamme, thanks for the great PR. Haven't checked the build yet myself but the commit looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219568967
Can you describe the maven build process? What version do you use, and what command do you type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219586971
Nice, I've been working on the eats for the last hour or so, so I'll update feature branch once this is done.
@matt did you merge this PR into feature branch? If so then thanks very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219566852
I can't compile this \u2014�Are you using Ivy here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by thammegowda <gi...@git.apache.org>.
Github user thammegowda commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219568358
This is based on Maven build.
Since the files are moved to new location in maven build, I branched off from JOSHUA-252 to avoid merge conflicts later time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-joshua/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by thammegowda <gi...@git.apache.org>.
Github user thammegowda commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219571959
@mjpost Added `maven-assembly-plugin` to make the build cycle easy: https://github.com/apache/incubator-joshua/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by thammegowda <gi...@git.apache.org>.
Github user thammegowda commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219570096
My maven version
<pre>
$ mvn --version
Apache Maven 3.0.5
Maven home: /usr/share/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.19.0-32-generic", arch: "amd64", family: "unix"
</pre>
To compile :
mvn clean compile
To package
mvn clean package # this fails if there are test failures
mvn clean package -DskipTests # to skip tests
To run main method in a class:
mvn compile exec:java -Dexec.mainClass=org.apache.joshua.decoder.JoshuaDecoder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219567425
Oh, I see, you are building off JOSHUA-252. We will need to merge that in with master first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---