You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "sdhzwc (via GitHub)" <gi...@apache.org> on 2024/08/13 10:11:01 UTC
[PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
sdhzwc opened a new pull request, #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
#16443
The effect is as follows：
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on code in PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#discussion_r1716168897
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Schedule.java:
##########
@@ -108,10 +108,21 @@ public class Schedule {
private int userId;
/**
- * created user name
+ * operator user id
+ */
+ private Integer operator;
Review Comment:
> It's better to set an explicit name like `modifyUserId`.
This one was written with reference to the previous naming, and I thought it would be better to keep it uniform, such as the one below:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2297889559
> > > > > It's better to set `modify_user` as create_user when upgrade.
> > > >
> > > >
> > > > What needs to be adjusted? Could you specify?
> > >
> > >
> > > It's not a good idea to make `modify_user_id` DEFAULT NULL, this will make confusion, why the create user is not null, but the modify_user_id can be null, no one can explain this. If the modify_user_id is null is this a bug?
> > > To avoid this kind problem, you need to inject a value for the new column, obviously you should use create_user to inject.
> >
> >
> > The reason is very simple. When the timer is created, it is definite. The creator is the logged-in person. At this time, there is no modification operation, so there is no need to specify the updater. I think it makes sense. If the updater is added, I think there will be ambiguity because there is no update operation yet.
>
> This is not a common practice, please reference the last_modify_user/last_modify_time in aws/linux.
It has been changed. The value has been added when inserting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on code in PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#discussion_r1716195699
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Schedule.java:
##########
@@ -108,10 +108,21 @@ public class Schedule {
private int userId;
/**
- * created user name
+ * operator user id
+ */
+ private Integer operator;
Review Comment:
> These are problems left over from history and will be reconstructed in the future
modifications completed
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Schedule.java:
##########
@@ -108,10 +108,21 @@ public class Schedule {
private int userId;
/**
- * created user name
+ * operator user id
+ */
+ private Integer operator;
Review Comment:
> These are problems left over from history and will be reconstructed in the future
Modifications completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2287954531
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2287744419
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2296792986
> > It's better to set `modify_user` as create_user when upgrade.
>
> What needs to be adjusted? Could you specify?
It's not a good idea to make `modify_user_id` DEFAULT NULL, this will make confusion, why the create user is not null, but the modify_user_id can be null, no one can explain this. If the modify_user_id is null is this a bug?
To avoid this kind problem, you need to inject a value for the new column, obviously you should use create_user to inject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2308607681
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc closed pull request #16450: [Improvement-16443][Workflow Timing] Improvement add operator
URL: https://github.com/apache/dolphinscheduler/pull/16450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2297860013
> > > > It's better to set `modify_user` as create_user when upgrade.
> > >
> > >
> > > What needs to be adjusted? Could you specify?
> >
> >
> > It's not a good idea to make `modify_user_id` DEFAULT NULL, this will make confusion, why the create user is not null, but the modify_user_id can be null, no one can explain this. If the modify_user_id is null is this a bug?
> > To avoid this kind problem, you need to inject a value for the new column, obviously you should use create_user to inject.
>
> The reason is very simple. When the timer is created, it is definite. The creator is the logged-in person. At this time, there is no modification operation, so there is no need to specify the updater. I think it makes sense. If the updater is added, I think there will be ambiguity because there is no update operation yet.
This is not a common practice, please reference the last_modify_user/last_modify_time in aws/linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on code in PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#discussion_r1716341708
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql:
##########
@@ -125,3 +125,5 @@ d//
delimiter ;
CALL drop_column_t_ds_alert_plugin_instance;
DROP PROCEDURE drop_column_t_ds_alert_plugin_instance;
+
+ALTER TABLE t_ds_schedules ADD `modify_user_id` int(11) DEFAULT NULL COMMENT 'modify user id';
Review Comment:
> Please leave a blank line at the end of each file.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2287954421
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2296801992
Additional, it's better to create a DSIP to unify the logic, we should add modify user to all table which have create user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2308607614
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [14.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2287661994
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2297778865
> nge.
Workflow Definition has Create User and Modify User.
Workflow Instance and Task Instance have Executor.
The following two are not clear and need to add corresponding Create User and Modify User. This can be handled as a DSIP: Workflow Timing and Task Definition.
> Additional, it's better to create a DSIP to unify the logic, we should add modify user to all table which have create user. Otherwise, this look like strange.
Workflow Definition has Create User and Modify User.
Workflow Instance and Task Instance have Executor.
The following two are not clear and need to add corresponding Create User and Modify User. This can be handled as a DSIP: Workflow Timing and Task Definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2287743430
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#discussion_r1716337743
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/postgresql/dolphinscheduler_ddl.sql:
##########
@@ -123,3 +123,5 @@ d//
select drop_column_t_ds_alert_plugin_instance();
DROP FUNCTION IF EXISTS drop_column_t_ds_alert_plugin_instance();
+
+ALTER TABLE t_ds_schedules ADD COLUMN IF NOT EXISTS modify_user_id int;
Review Comment:
Same here.
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql:
##########
@@ -125,3 +125,5 @@ d//
delimiter ;
CALL drop_column_t_ds_alert_plugin_instance;
DROP PROCEDURE drop_column_t_ds_alert_plugin_instance;
+
+ALTER TABLE t_ds_schedules ADD `modify_user_id` int(11) DEFAULT NULL COMMENT 'modify user id';
Review Comment:
Please leave a blank line at the end of each file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#discussion_r1716170026
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Schedule.java:
##########
@@ -108,10 +108,21 @@ public class Schedule {
private int userId;
/**
- * created user name
+ * operator user id
+ */
+ private Integer operator;
Review Comment:
These are problems left over from history and will be reconstructed in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2295590547
> It's better to set `modify_user` as create_user when upgrade.
Do you need to make any adjustments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2297772236
> > > It's better to set `modify_user` as create_user when upgrade.
> >
> >
> > What needs to be adjusted? Could you specify?
>
> It's not a good idea to make `modify_user_id` DEFAULT NULL, this will make confusion, why the create user is not null, but the modify_user_id can be null, no one can explain this. If the modify_user_id is null is this a bug?
>
> To avoid this kind problem, you need to inject a value for the new column, obviously you should use create_user to inject.
The reason is very simple. When the timer is created, it is definite. The creator is the logged-in person. At this time, there is no modification operation, so there is no need to specify the updater. I think it makes sense. If the updater is added, I think there will be ambiguity because there is no update operation yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2297779173
> Additional, it's better to create a DSIP to unify the logic, we should add modify user to all table which have create user. Otherwise, this look like strange.
Workflow Definition has Create User and Modify User.
Workflow Instance and Task Instance have Executor.
The following two are not clear and need to add corresponding Create User and Modify User. This can be handled as a DSIP: Workflow Timing and Task Definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#issuecomment-2287661122
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16450&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16443][Workflow Timing] Improvement add operator [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16450:
URL: https://github.com/apache/dolphinscheduler/pull/16450#discussion_r1716165481
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Schedule.java:
##########
@@ -108,10 +108,21 @@ public class Schedule {
private int userId;
/**
- * created user name
+ * operator user id
+ */
+ private Integer operator;
Review Comment:
It's better to set an explicit name like `modifyUserId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org