You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/09/07 18:21:34 UTC
svn commit: r1881544 -
/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java
Author: tilman
Date: Mon Sep 7 18:21:34 2020
New Revision: 1881544
URL: http://svn.apache.org/viewvc?rev=1881544&view=rev
Log:
PDFBOX-4892: SonarQube fix
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java?rev=1881544&r1=1881543&r2=1881544&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java Mon Sep 7 18:21:34 2020
@@ -55,6 +55,7 @@ import org.apache.pdfbox.pdmodel.interac
import org.apache.pdfbox.pdmodel.interactive.form.PDAcroForm;
import org.apache.pdfbox.pdmodel.interactive.form.PDField;
import org.apache.pdfbox.rendering.PDFRenderer;
+import org.junit.Assert;
/**
* Test suite for PDFMergerUtility.
@@ -837,12 +838,12 @@ public class PDFMergerUtilityTest extend
COSBase item = kdict.getItem(COSName.OBJ);
if (item instanceof COSObject)
{
- assertTrue("Annotation page is not in the page tree: " + item, pageTree.indexOf(page) != -1);
+ Assert.assertNotEquals("Annotation page is not in the page tree: " + item, -1, pageTree.indexOf(page));
}
else
{
// don't display because of stack overflow
- assertTrue("Annotation page is not in the page tree", pageTree.indexOf(page) != -1);
+ Assert.assertNotEquals("Annotation page is not in the page tree", -1, pageTree.indexOf(page));
}
}
}
@@ -934,7 +935,7 @@ public class PDFMergerUtilityTest extend
PDPage page = structureElement.getPage();
if (page != null)
{
- assertTrue("Page is not in the page tree", pageTree.indexOf(page) != -1);
+ Assert.assertNotEquals("Page is not in the page tree", -1, pageTree.indexOf(page));
}
}
}