[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3810: Artemis 3538 Removing // --------- comments from the codebase

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3810:
URL: https://github.com/apache/activemq-artemis/pull/3810#discussion_r734729322



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ActiveMQProtonRemotingConnection.java
##########
@@ -67,9 +67,6 @@ public void scheduledFlush() {
       amqpConnection.scheduledFlush();
    }
 
-   /*
-    * This can be called concurrently by more than one thread so needs to be locked

Review comment:
       why did you remove this comment?
   
   The task is about removing a set of comments like this:
   ```java
   / Constants -----------------------------------------------------
   // Attributes ----------------------------------------------------
   // Static --------------------------------------------------------
   // Constructors --------------------------------------------------
   ```
   
   do a search around the code base and you will see those...
   
   many years ago we used to have a template for new classes, where we would place constants within these comments...
   
   and they are out of fashion today.
   
   
   This task is about removing all of those.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org