[jira] [Comment Edited] (TS-4099) replace XML statistics with Lua

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091398#comment-15091398 ] 

Leif Hedstrom edited comment on TS-4099 at 1/11/16 3:57 AM:
------------------------------------------------------------

We made LuaJIT optional, per your request if you recall :). Which disables the Lua plugin. If we introduce Lua into the core, I think we have to make something such that we can still run ASAN.

I don't know when/why we removed the option to have an external Lua library instead of LuaJIT, but that seems like one viable option. I don't know if there's a way to ignore ASAN from the LuaJIT, but maybe it's enough to just exclude the ASAN instrumentation when building LuaJIT? This might be the best option (if it works), combining it with a new --with-asan option (to make it clear to the components that ASAN was enabled or not).


was (Author: zwoop):
We made LuaJIT optional, per you're request, if you recall :). Which disables the Lua plugin. If we introduce Lua into the core, I think we have to make something such that we can still run ASAN.

I don't know when/why we removed the option to have an external Lua library instead of LuaJIT, but that seems like one viable option. I don't know if there's a way to ignore ASAN from the LuaJIT, but maybe it's enough to just exclude the ASAN instrumentation when building LuaJIT? This might be the best option (if it works), combining it with a new --with-asan option (to make it clear to the components that ASAN was enabled or not).

> replace XML statistics with Lua
> -------------------------------
>
>                 Key: TS-4099
>                 URL: https://issues.apache.org/jira/browse/TS-4099
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Lua, Manager, Metrics
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 6.2.0
>
>
> The custom metrics XML format is undocumented and difficult to use and extend. Since we plan to use Lua for configuration programmability, lets make a start by replacing this subsystem with Lua.
> It turns out that Lua is mostly more readable and easier to understand. Performance is roughly similar.
> Example syntax:
> {code}
> float 'proxy.node.user_agent_total_bytes_avg_10s' [[
>   local self = ...
>   return interval_delta_of_10s(self, function()
>     return proxy.node.user_agent_total_bytes
>   end)
> ]]
> counter 'proxy.node.origin_server_total_bytes' [[
>   return proxy.node.http.origin_server_total_request_bytes +
>     proxy.node.http.origin_server_total_response_bytes +
>     proxy.node.http.parent_proxy_total_request_bytes +
>     proxy.node.http.parent_proxy_total_response_bytes
> ]]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)