You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by David Blevins <da...@gmail.com> on 2012/07/04 02:09:32 UTC

Github pull requests

Just noticed that the Thrift mirror on Github has a long history of pull requests.  That's so cool.

How exactly did you pull it off?

Would love to copy that for OpenEJB/TomEE.

I'm not really a git user, but anything to make it easier for people to contribute is worth pursuing.


-David


Re: Github pull requests

Posted by ro...@bufferoverflow.ch.
We did nothing... The infrastructure team had set up a redirect of  
pull requests to the developer mailing list of the projects.

have you already to created a pull request on github?
if you do not receive a mail on the dev list, please ask the infra  
team on their mailing list.


;-r


Quoting David Blevins <da...@gmail.com>:

>
> On Jul 4, 2012, at 11:43 AM, Roger Meier wrote:
>
>> Hi David
>>
>>> How exactly did you pull it off?
>> We comment from time to time on github, but jira is the primary tool.
>
> I really meant how do you do it technically.  Is there something you  
> had to setup to get notified of pull requests?
>
>
> -David
>
>
>
>



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.


Re: Github pull requests

Posted by David Blevins <da...@gmail.com>.
On Jul 4, 2012, at 11:43 AM, Roger Meier wrote:

> Hi David
> 
>> How exactly did you pull it off?
> We comment from time to time on github, but jira is the primary tool.

I really meant how do you do it technically.  Is there something you had to setup to get notified of pull requests?


-David


AW: Github pull requests

Posted by Roger Meier <ro...@bufferoverflow.ch>.
Hi David

> How exactly did you pull it off?
We comment from time to time on github, but jira is the primary tool.

We have a very difficult code base to manage, super cross language! => 20
That's why we have tons of forks :-( 
... and github is popular to share

The main issue with such contributions is the license...
Code attachments within Jira have the following optional statement for file
uploads:
"Grant license to ASF for inclusion in ASF works (as per the Apache License
§5)"

I think we should have a clear statement on our Apache github organization
web site => every contribution to an Apache project is a direct "grant
license to ASF"
This will allow us to process pull requests more efficiently.

All the best!
roger
;-r

PS: I'm looking forward to an Apache Allura based code farming and social
coding platform;-)

> -----Ursprüngliche Nachricht-----
> Von: David Blevins [mailto:david.blevins@gmail.com]
> Gesendet: Mittwoch, 4. Juli 2012 02:10
> An: dev@thrift.apache.org
> Betreff: Github pull requests
> 
> Just noticed that the Thrift mirror on Github has a long history of pull
> requests.  That's so cool.
> 
> How exactly did you pull it off?
> 
> Would love to copy that for OpenEJB/TomEE.
> 
> I'm not really a git user, but anything to make it easier for people to
> contribute is worth pursuing.
> 
> 
> -David
> 
>