You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kl...@apache.org on 2017/08/22 22:37:45 UTC

[3/4] geode git commit: GEODE-3335: add FlakyTest category to testNavigationAPIS

GEODE-3335: add FlakyTest category to testNavigationAPIS


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/c95b32ee
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/c95b32ee
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/c95b32ee

Branch: refs/heads/develop
Commit: c95b32ee8c95f2a95767ce771eb6b2f5ee8492c7
Parents: a1ac45d
Author: Kirk Lund <kl...@apache.org>
Authored: Tue Aug 22 14:23:09 2017 -0700
Committer: Kirk Lund <kl...@apache.org>
Committed: Tue Aug 22 15:37:35 2017 -0700

----------------------------------------------------------------------
 .../geode/management/RegionManagementDUnitTest.java  | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/c95b32ee/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java b/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java
index cb35663..ee7cb95 100644
--- a/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java
@@ -30,11 +30,14 @@ package org.apache.geode.management;
 
 import static java.lang.management.ManagementFactory.getPlatformMBeanServer;
 import static java.util.concurrent.TimeUnit.MINUTES;
-import static org.apache.geode.cache.Region.*;
-import static org.apache.geode.management.internal.MBeanJMXAdapter.*;
-import static org.apache.geode.test.dunit.Host.*;
+import static org.apache.geode.cache.Region.SEPARATOR;
+import static org.apache.geode.management.internal.MBeanJMXAdapter.getDistributedRegionMbeanName;
+import static org.apache.geode.management.internal.MBeanJMXAdapter.getMemberMBeanName;
+import static org.apache.geode.management.internal.MBeanJMXAdapter.getRegionMBeanName;
+import static org.apache.geode.test.dunit.Host.getHost;
 import static org.apache.geode.test.dunit.Invoke.invokeInEveryVM;
-import static org.assertj.core.api.Assertions.*;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -47,7 +50,6 @@ import javax.management.Notification;
 import javax.management.NotificationListener;
 import javax.management.ObjectName;
 
-import org.apache.geode.test.junit.categories.FlakyTest;
 import org.awaitility.Awaitility;
 import org.awaitility.core.ConditionFactory;
 import org.junit.After;
@@ -80,6 +82,7 @@ import org.apache.geode.management.internal.MBeanJMXAdapter;
 import org.apache.geode.management.internal.SystemManagementService;
 import org.apache.geode.test.dunit.VM;
 import org.apache.geode.test.junit.categories.DistributedTest;
+import org.apache.geode.test.junit.categories.FlakyTest;
 
 /**
  * This class checks and verifies various data and operations exposed through RegionMXBean
@@ -91,7 +94,6 @@ import org.apache.geode.test.junit.categories.DistributedTest;
  * TODO: complete refactoring this test to use ManagementTestRule
  */
 @Category(DistributedTest.class)
-@SuppressWarnings({"serial", "unused"})
 public class RegionManagementDUnitTest extends ManagementTestBase {
 
   private static final String REGION_NAME = "MANAGEMENT_TEST_REGION";
@@ -263,6 +265,7 @@ public class RegionManagementDUnitTest extends ManagementTestBase {
   }
 
   @Test
+  @Category(FlakyTest.class) // GEODE-3335
   public void testNavigationAPIS() throws Exception {
     createManagersAndThenMembers_tmp();