You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/07 14:07:57 UTC

[GitHub] [spark] zero323 commented on pull request #34774: [SPARK-37516][PYTHON][SQL] Uses Python's standard string formatter for SQL API in PySpark

zero323 commented on pull request #34774:
URL: https://github.com/apache/spark/pull/34774#issuecomment-987958331


   In general LGTM. The only thing ‒ given
   
   > Let me keep it only in API documentation first .. I would like to avoid promoting this support a lot for now .. but keep it unstable and experimental.
   
   shouldn't we keep old `sql` docstring for now?  The new one seems to imply more than we guarantee right now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org