You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Nalley <da...@gnsa.us> on 2012/12/22 01:17:08 UTC
Feature proposals and testing
Hi folks:
I've seen a number of feature proposals coming through in the past
week. Almost universally there seems to be almost zero discussion of
testing for the proposed features.
I personally, do not consider a feature to complete without a plan to
test - and almost certainly in automated test format via marvin. For
most features I'd also consider it incomplete without significant unit
test coverage.
Please make sure you have a plan that focuses on testing all these
wonderful new features you are writing.
--David
RE: Feature proposals and testing
Posted by Sudha Ponnaganti <su...@citrix.com>.
Majority of the feature postings are just proposals and not Functional specification or design documents.
I have been following these and reviewing. Where applicable will be providing some input on test plans for functional validations.
Would expect that unit test would be part of the design itself though.
-----Original Message-----
From: Alex Huang [mailto:Alex.Huang@citrix.com]
Sent: Friday, December 21, 2012 4:32 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: Feature proposals and testing
+1 on the testing.
I do believe a lot of the features so far haven't reach a phase where we can discuss testing yet but that's definitely very important.
--Alex
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Friday, December 21, 2012 4:17 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Feature proposals and testing
>
> Hi folks:
>
> I've seen a number of feature proposals coming through in the past
> week. Almost universally there seems to be almost zero discussion of
> testing for the proposed features.
>
> I personally, do not consider a feature to complete without a plan to
> test - and almost certainly in automated test format via marvin. For
> most features I'd also consider it incomplete without significant unit
> test coverage.
>
> Please make sure you have a plan that focuses on testing all these
> wonderful new features you are writing.
>
> --David
Re: Feature proposals and testing
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Dec 21, 2012 at 7:32 PM, Alex Huang <Al...@citrix.com> wrote:
> +1 on the testing.
>
> I do believe a lot of the features so far haven't reach a phase where we can discuss testing yet but that's definitely very important.
We should be at this stage now... test planning needs to be part of
the feature work, or we're really going to struggle to integrate all
of the currently proposed features / changes.
> --Alex
>
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: Friday, December 21, 2012 4:17 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Feature proposals and testing
>>
>> Hi folks:
>>
>> I've seen a number of feature proposals coming through in the past
>> week. Almost universally there seems to be almost zero discussion of
>> testing for the proposed features.
>>
>> I personally, do not consider a feature to complete without a plan to
>> test - and almost certainly in automated test format via marvin. For
>> most features I'd also consider it incomplete without significant unit
>> test coverage.
>>
>> Please make sure you have a plan that focuses on testing all these
>> wonderful new features you are writing.
>>
>> --David
>
RE: Feature proposals and testing
Posted by Alex Huang <Al...@citrix.com>.
+1 on the testing.
I do believe a lot of the features so far haven't reach a phase where we can discuss testing yet but that's definitely very important.
--Alex
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Friday, December 21, 2012 4:17 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Feature proposals and testing
>
> Hi folks:
>
> I've seen a number of feature proposals coming through in the past
> week. Almost universally there seems to be almost zero discussion of
> testing for the proposed features.
>
> I personally, do not consider a feature to complete without a plan to
> test - and almost certainly in automated test format via marvin. For
> most features I'd also consider it incomplete without significant unit
> test coverage.
>
> Please make sure you have a plan that focuses on testing all these
> wonderful new features you are writing.
>
> --David
RE: Feature proposals and testing
Posted by Edison Su <Ed...@citrix.com>.
I have a sample code to test hypervisor resource directly(only for direct connected agent(there is a resource loaded by mgt server)):
https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;f=engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java;h=371e6d0eb87d85ccef04300f4e4915aa5c0978d5;hb=refs/heads/javelin
You can send command directly to resource in Eclipse, without start a mgt server. Very nice for unit test.
> -----Original Message-----
> From: Donal Lafferty [mailto:donal.lafferty@citrix.com]
> Sent: Sunday, December 23, 2012 3:58 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Feature proposals and testing
>
> Okay, so here's a question on reuse.
>
> Are there sample hypervisor control commands in the code base?
>
> At the moment, I dump JSON versions of commands to log, and use this
> JSON as the basis of my unit tests. To save time, I'd like access to
> permutations of existing command objects and the sequence that they're
> called in. E.g. for new VM you should see a CreateCommand before a
> StartCommand.
>
> Can anyone point to a map or list of reusable tests in the code base? For
> now, reuse in the sense of copy/paste/hack would suffice.
>
>
> DL
>
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: 22 December 2012 12:17 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Feature proposals and testing
>
> Hi folks:
>
> I've seen a number of feature proposals coming through in the past week.
> Almost universally there seems to be almost zero discussion of testing for
> the proposed features.
>
> I personally, do not consider a feature to complete without a plan to test -
> and almost certainly in automated test format via marvin. For most features
> I'd also consider it incomplete without significant unit test coverage.
>
> Please make sure you have a plan that focuses on testing all these
> wonderful new features you are writing.
>
> --David
RE: Feature proposals and testing
Posted by Donal Lafferty <do...@citrix.com>.
Okay, so here's a question on reuse.
Are there sample hypervisor control commands in the code base?
At the moment, I dump JSON versions of commands to log, and use this JSON as the basis of my unit tests. To save time, I'd like access to permutations of existing command objects and the sequence that they're called in. E.g. for new VM you should see a CreateCommand before a StartCommand.
Can anyone point to a map or list of reusable tests in the code base? For now, reuse in the sense of copy/paste/hack would suffice.
DL
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: 22 December 2012 12:17 AM
To: cloudstack-dev@incubator.apache.org
Subject: Feature proposals and testing
Hi folks:
I've seen a number of feature proposals coming through in the past week. Almost universally there seems to be almost zero discussion of testing for the proposed features.
I personally, do not consider a feature to complete without a plan to test - and almost certainly in automated test format via marvin. For most features I'd also consider it incomplete without significant unit test coverage.
Please make sure you have a plan that focuses on testing all these wonderful new features you are writing.
--David