You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nongli <gi...@git.apache.org> on 2016/03/02 01:00:15 UTC
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
GitHub user nongli opened a pull request:
https://github.com/apache/spark/pull/11454
[SPARK-13574][SQL] Add benchmark to measure string dictionary decode.
## What changes were proposed in this pull request?
Also updated the other benchmarks when the default to use vectorized decode was flipped.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nongli/spark benchmark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11454
----
commit ca08fd49773debcd886582eb1cbd2fd901196e49
Author: Nong Li <no...@databricks.com>
Date: 2016-03-01T23:54:02Z
[SPARK-13574][SQL] Add benchmark to measure string dictionary decode.
Also updated the other benchmarks when the default to use vectorized decode was flipped.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-190978203
**[Test build #52266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52266/consoleFull)** for PR 11454 at commit [`ca08fd4`](https://github.com/apache/spark/commit/ca08fd49773debcd886582eb1cbd2fd901196e49).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191422762
**[Test build #52336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52336/consoleFull)** for PR 11454 at commit [`cef9114`](https://github.com/apache/spark/commit/cef9114d411029e787c30ee479072579aad2ab95).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11454#discussion_r54659878
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala ---
@@ -72,7 +72,7 @@ object ParquetReadBenchmark {
.write.parquet(dir.getCanonicalPath)
sqlContext.read.parquet(dir.getCanonicalPath).registerTempTable("tempTable")
- sqlBenchmark.addCase("SQL Parquet Reader") { iter =>
+ sqlBenchmark.addCase("SQL Parquet Vectorized") { iter =>
sqlContext.sql("select sum(id) from tempTable").collect()
--- End diff --
Could we also enable PARQUET_VECTORIZED_READER_ENABLED here?
Today I just ran into a issue when I have a conf/spark-default.conf that have PARQUET_VECTORIZED_READER_ENABLED in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11454#discussion_r54661330
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala ---
@@ -219,11 +216,43 @@ object ParquetReadBenchmark {
/*
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Int and String Scan: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative
- -------------------------------------------------------------------------------
- SQL Parquet Reader 1381 / 1679 7.6 131.7 1.0X
- SQL Parquet MR 2005 / 2177 5.2 191.2 0.7X
- SQL Parquet Vectorized 919 / 1044 11.4 87.6 1.5X
- ParquetReader 1035 / 1163 10.1 98.7 1.3X
+ -------------------------------------------------------------------------------------------
+ SQL Parquet Vectorized 1025 / 1180 10.2 97.8 1.0X
+ SQL Parquet MR 2157 / 2222 4.9 205.7 0.5X
+ SQL Parquet Non-vectorized 1450 / 1466 7.2 138.3 0.7X
+ ParquetReader 1005 / 1022 10.4 95.9 1.0X
--- End diff --
I see, could you append "Non-vectorized" after the name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11454#discussion_r54660062
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala ---
@@ -219,11 +216,43 @@ object ParquetReadBenchmark {
/*
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Int and String Scan: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative
- -------------------------------------------------------------------------------
- SQL Parquet Reader 1381 / 1679 7.6 131.7 1.0X
- SQL Parquet MR 2005 / 2177 5.2 191.2 0.7X
- SQL Parquet Vectorized 919 / 1044 11.4 87.6 1.5X
- ParquetReader 1035 / 1163 10.1 98.7 1.3X
+ -------------------------------------------------------------------------------------------
+ SQL Parquet Vectorized 1025 / 1180 10.2 97.8 1.0X
+ SQL Parquet MR 2157 / 2222 4.9 205.7 0.5X
+ SQL Parquet Non-vectorized 1450 / 1466 7.2 138.3 0.7X
+ ParquetReader 1005 / 1022 10.4 95.9 1.0X
--- End diff --
Do you know why the first on is as fast as this one (only 20ms slower)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by nongli <gi...@git.apache.org>.
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11454#discussion_r54660492
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala ---
@@ -219,11 +216,43 @@ object ParquetReadBenchmark {
/*
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Int and String Scan: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative
- -------------------------------------------------------------------------------
- SQL Parquet Reader 1381 / 1679 7.6 131.7 1.0X
- SQL Parquet MR 2005 / 2177 5.2 191.2 0.7X
- SQL Parquet Vectorized 919 / 1044 11.4 87.6 1.5X
- ParquetReader 1035 / 1163 10.1 98.7 1.3X
+ -------------------------------------------------------------------------------------------
+ SQL Parquet Vectorized 1025 / 1180 10.2 97.8 1.0X
+ SQL Parquet MR 2157 / 2222 4.9 205.7 0.5X
+ SQL Parquet Non-vectorized 1450 / 1466 7.2 138.3 0.7X
+ ParquetReader 1005 / 1022 10.4 95.9 1.0X
--- End diff --
The last one is the 1.6 parquet reader. What this is comparing, some what randomly, is the 1.6 reader without spark (last row) vs the vectorized reader with all of spark (first row).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191015229
**[Test build #52266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52266/consoleFull)** for PR 11454 at commit [`ca08fd4`](https://github.com/apache/spark/commit/ca08fd49773debcd886582eb1cbd2fd901196e49).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191015525
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191465949
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191465956
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52336/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191426525
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191015528
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52266/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191483009
Merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13574][SQL] Add benchmark to measure st...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11454#issuecomment-191464781
**[Test build #52336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52336/consoleFull)** for PR 11454 at commit [`cef9114`](https://github.com/apache/spark/commit/cef9114d411029e787c30ee479072579aad2ab95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org