[GitHub] [samza] Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container Placement Service (core functionality) for container move and restart

[GitBox <gi...@apache.org>]

Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r348676882
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
 ##########
 @@ -110,7 +110,7 @@
    */
   protected final ResourceRequestState resourceRequestState;
   /**
-   * Tracks the expiration of a request for resources.
+   * Tracks the default expiration of a request for resources.
 
 Review comment:
   Changed it to: `Tracks the configured expiration of a resource request set by the config {@code ClusterManagerConfig#CLUSTER_MANAGER_REQUEST_TIMEOUT_MS} which defaults to value {@code ClusterManagerConfig#DEFAULT_CONTAINER_REQUEST_TIMEOUT_MS}`
   
   @mynameborat the default is 5000 ms set in code, this value is optionally overridden for Container Placement Actions check: ContainerAllocator#isRequestExpired  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services