[GitHub] [spark] HyukjinKwon commented on a change in pull request #33706: [SPARK-36477][SQL] Inferring schema from JSON file shall respect ignoreCorruptFiles and handle IOE

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33706:
URL: https://github.com/apache/spark/pull/33706#discussion_r686687370



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ShufflePartitionsUtil.scala
##########
@@ -257,7 +257,6 @@ object ShufflePartitionsUtil extends Logging {
         totalSizeOfCurrentPartition += mapOutputStatistics(j).bytesByPartitionId(i)
         j += 1
       }
-

Review comment:
       let's revert this change back .. 

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -53,7 +55,8 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
    */
   def infer[T](
       json: RDD[T],
-      createParser: (JsonFactory, T) => JsonParser): StructType = {
+      createParser: (JsonFactory, T) => JsonParser,
+      ignoreCorruptFiles: Boolean): StructType = {

Review comment:
       Can we get it from `SQLConf.get`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org