You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/11/23 22:18:17 UTC
[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] opened a new pull request, #28: Bump engine.io and socket.io in /it
dependabot[bot] opened a new pull request, #28:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28
Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together.
Updates `engine.io` from 3.5.0 to 3.6.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/engine.io/releases">engine.io's releases</a>.</em></p>
<blockquote>
<h2>3.6.1</h2>
<p>:warning: This release contains an important security fix :warning:</p>
<p>A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process:</p>
<pre><code>Error: read ECONNRESET
at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
Emitted 'error' event on Socket instance at:
at emitErrorNT (internal/streams/destroy.js:106:8)
at emitErrorCloseNT (internal/streams/destroy.js:74:3)
at processTicksAndRejections (internal/process/task_queues.js:80:21) {
errno: -104,
code: 'ECONNRESET',
syscall: 'read'
}
</code></pre>
<p>Please upgrade as soon as possible.</p>
<h3>Bug Fixes</h3>
<ul>
<li>catch errors when destroying invalid upgrades (<a href="https://github.com/socketio/engine.io/commit/83c4071af871fc188298d7d591e95670bf9f9085">83c4071</a>)</li>
</ul>
<h2>3.6.0</h2>
<h3>Bug Fixes</h3>
<ul>
<li>add extension in the package.json main entry (<a href="https://github-redirect.dependabot.com/socketio/engine.io/issues/608">#608</a>) (<a href="https://github.com/socketio/engine.io/commit/3ad0567dbd57cfb7c2ff4e8b7488d80f37022b4a">3ad0567</a>)</li>
<li>do not reset the ping timer after upgrade (<a href="https://github.com/socketio/engine.io/commit/1f5d4699862afee1e410fcb0e1f5e751ebcd2f9f">1f5d469</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>decrease the default value of maxHttpBufferSize (<a href="https://github.com/socketio/engine.io/commit/58e274c437e9cbcf69fd913c813aad8fbd253703">58e274c</a>)</li>
</ul>
<p>This change reduces the default value from 100 mb to a more sane 1 mb.</p>
<p>This helps protect the server against denial of service attacks by malicious clients sending huge amounts of data.</p>
<p>See also: <a href="https://github.com/advisories/GHSA-j4f2-536g-r55m">https://github.com/advisories/GHSA-j4f2-536g-r55m</a></p>
<ul>
<li>increase the default value of pingTimeout (<a href="https://github.com/socketio/engine.io/commit/f55a79a28a5fbc6c9edae876dd11308b89cc979e">f55a79a</a>)</li>
</ul>
<h4>Links</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/engine.io/compare/3.5.0...3.6.0">https://github.com/socketio/engine.io/compare/3.5.0...3.6.0</a></li>
<li>Client release: -</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/engine.io/blob/main/CHANGELOG.md">engine.io's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/socketio/engine.io/compare/3.6.0...3.6.1">3.6.1</a> (2022-11-20)</h2>
<p>:warning: This release contains an important security fix :warning:</p>
<p>A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process:</p>
<pre><code>Error: read ECONNRESET
at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
Emitted 'error' event on Socket instance at:
at emitErrorNT (internal/streams/destroy.js:106:8)
at emitErrorCloseNT (internal/streams/destroy.js:74:3)
at processTicksAndRejections (internal/process/task_queues.js:80:21) {
errno: -104,
code: 'ECONNRESET',
syscall: 'read'
}
</code></pre>
<p>Please upgrade as soon as possible.</p>
<h3>Bug Fixes</h3>
<ul>
<li>catch errors when destroying invalid upgrades (<a href="https://github.com/socketio/engine.io/commit/83c4071af871fc188298d7d591e95670bf9f9085">83c4071</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/engine.io/compare/6.2.0...6.2.1">6.2.1</a> (2022-11-20)</h2>
<p>:warning: This release contains an important security fix :warning:</p>
<p>A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process:</p>
<pre><code>Error: read ECONNRESET
at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
Emitted 'error' event on Socket instance at:
at emitErrorNT (internal/streams/destroy.js:106:8)
at emitErrorCloseNT (internal/streams/destroy.js:74:3)
at processTicksAndRejections (internal/process/task_queues.js:80:21) {
errno: -104,
code: 'ECONNRESET',
syscall: 'read'
}
</code></pre>
<p>Please upgrade as soon as possible.</p>
<h3>Bug Fixes</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/socketio/engine.io/commit/67a3a8785900f77d8ad40c3c1eea8ee188c42d95"><code>67a3a87</code></a> chore(release): 3.6.1</li>
<li><a href="https://github.com/socketio/engine.io/commit/83c4071af871fc188298d7d591e95670bf9f9085"><code>83c4071</code></a> fix: catch errors when destroying invalid upgrades</li>
<li><a href="https://github.com/socketio/engine.io/commit/f62f26530cdb9c7bbfd295f3110cc2d911561fda"><code>f62f265</code></a> chore(release): 3.6.0</li>
<li><a href="https://github.com/socketio/engine.io/commit/f55a79a28a5fbc6c9edae876dd11308b89cc979e"><code>f55a79a</code></a> feat: increase the default value of pingTimeout</li>
<li><a href="https://github.com/socketio/engine.io/commit/1f5d4699862afee1e410fcb0e1f5e751ebcd2f9f"><code>1f5d469</code></a> fix: do not reset the ping timer after upgrade</li>
<li><a href="https://github.com/socketio/engine.io/commit/3ad0567dbd57cfb7c2ff4e8b7488d80f37022b4a"><code>3ad0567</code></a> fix: add extension in the package.json main entry (<a href="https://github-redirect.dependabot.com/socketio/engine.io/issues/608">#608</a>)</li>
<li><a href="https://github.com/socketio/engine.io/commit/58e274c437e9cbcf69fd913c813aad8fbd253703"><code>58e274c</code></a> feat: decrease the default value of maxHttpBufferSize</li>
<li>See full diff in <a href="https://github.com/socketio/engine.io/compare/3.5.0...3.6.1">compare view</a></li>
</ul>
</details>
<br />
Updates `socket.io` from 2.4.1 to 2.5.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p>
<blockquote>
<h2>2.5.0</h2>
<p>:warning: WARNING :warning:</p>
<p>The default value of the <code>maxHttpBufferSize</code> option has been decreased from 100 MB to 1 MB, in order to prevent attacks by denial of service.</p>
<p>Security advisory: <a href="https://github.com/advisories/GHSA-j4f2-536g-r55m">https://github.com/advisories/GHSA-j4f2-536g-r55m</a></p>
<h3>Bug Fixes</h3>
<ul>
<li>fix race condition in dynamic namespaces (<a href="https://github.com/socketio/socket.io/commit/05e1278cfa99f3ecf3f8f0531ffe57d850e9a05b">05e1278</a>)</li>
<li>ignore packet received after disconnection (<a href="https://github.com/socketio/socket.io/commit/22d4bdf00d1a03885dc0171125faddfaef730066">22d4bdf</a>)</li>
<li>only set 'connected' to true after middleware execution (<a href="https://github.com/socketio/socket.io/commit/226cc16165f9fe60f16ff4d295fb91c8971cde35">226cc16</a>)</li>
<li>prevent the socket from joining a room after disconnection (<a href="https://github.com/socketio/socket.io/commit/f223178eb655a7713303b21a78f9ef9e161d6458">f223178</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/2.4.1...2.5.0">https://github.com/socketio/socket.io/compare/2.4.1...2.5.0</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/2.5.0">2.5.0</a></li>
<li>engine.io version: <code>~3.6.0</code> (<a href="https://github.com/socketio/engine.io/compare/3.5.0...3.6.0">diff</a>)</li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/main/CHANGELOG.md">socket.io's changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/socketio/socket.io/compare/2.4.1...2.5.0">2.5.0</a> (2022-06-26)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>fix race condition in dynamic namespaces (<a href="https://github.com/socketio/socket.io/commit/05e1278cfa99f3ecf3f8f0531ffe57d850e9a05b">05e1278</a>)</li>
<li>ignore packet received after disconnection (<a href="https://github.com/socketio/socket.io/commit/22d4bdf00d1a03885dc0171125faddfaef730066">22d4bdf</a>)</li>
<li>only set 'connected' to true after middleware execution (<a href="https://github.com/socketio/socket.io/commit/226cc16165f9fe60f16ff4d295fb91c8971cde35">226cc16</a>)</li>
<li>prevent the socket from joining a room after disconnection (<a href="https://github.com/socketio/socket.io/commit/f223178eb655a7713303b21a78f9ef9e161d6458">f223178</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/4.5.0...4.5.1">4.5.1</a> (2022-05-17)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>forward the local flag to the adapter when using fetchSockets() (<a href="https://github.com/socketio/socket.io/commit/30430f0985f8e7c49394543d4c84913b6a15df60">30430f0</a>)</li>
<li><strong>typings:</strong> add HTTPS server to accepted types (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4351">#4351</a>) (<a href="https://github.com/socketio/socket.io/commit/9b43c9167cff817c60fa29dbda2ef7cd938aff51">9b43c91</a>)</li>
</ul>
<h1><a href="https://github.com/socketio/socket.io/compare/4.4.1...4.5.0">4.5.0</a> (2022-04-23)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>typings:</strong> ensure compatibility with TypeScript 3.x (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/4259">#4259</a>) (<a href="https://github.com/socketio/socket.io/commit/02c87a85614e217b8e7b93753f315790ae9d99f6">02c87a8</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>add support for catch-all listeners for outgoing packets (<a href="https://github.com/socketio/socket.io/commit/531104d332690138b7aab84d5583d6204132c8b4">531104d</a>)</li>
</ul>
<p>This is similar to <code>onAny()</code>, but for outgoing packets.</p>
<p>Syntax:</p>
<pre lang="js"><code>socket.onAnyOutgoing((event, ...args) => {
console.log(event);
});
</code></pre>
<ul>
<li>broadcast and expect multiple acks (<a href="https://github.com/socketio/socket.io/commit/8b204570a94979bbec307f23ca078f30f5cf07b0">8b20457</a>)</li>
</ul>
<p>Syntax:</p>
<pre lang="js"><code>io.timeout(1000).emit("some-event", (err, responses) => {
</tr></table>
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/socketio/socket.io/commit/baa6804440fe5dc98fcbd5249dee2f4fa6ef1b8a"><code>baa6804</code></a> chore(release): 2.5.0</li>
<li><a href="https://github.com/socketio/socket.io/commit/f223178eb655a7713303b21a78f9ef9e161d6458"><code>f223178</code></a> fix: prevent the socket from joining a room after disconnection</li>
<li><a href="https://github.com/socketio/socket.io/commit/226cc16165f9fe60f16ff4d295fb91c8971cde35"><code>226cc16</code></a> fix: only set 'connected' to true after middleware execution</li>
<li><a href="https://github.com/socketio/socket.io/commit/05e1278cfa99f3ecf3f8f0531ffe57d850e9a05b"><code>05e1278</code></a> fix: fix race condition in dynamic namespaces</li>
<li><a href="https://github.com/socketio/socket.io/commit/22d4bdf00d1a03885dc0171125faddfaef730066"><code>22d4bdf</code></a> fix: ignore packet received after disconnection</li>
<li><a href="https://github.com/socketio/socket.io/commit/dfded535933ad29d37b0784ed98040090ad860c6"><code>dfded53</code></a> chore: update engine.io version to 3.6.0</li>
<li>See full diff in <a href="https://github.com/socketio/socket.io/compare/2.4.1...2.5.0">compare view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/sling-org-apache-sling-app-cms/network/alerts).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] commented on pull request #28: Bump engine.io and socket.io in /it
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on PR #28:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28#issuecomment-1375068690
Looks like these dependencies are up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-app-cms] sonarcloud[bot] commented on pull request #28: Bump engine.io and socket.io in /it
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #28:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28#issuecomment-1325735949
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-app-cms&pullRequest=28)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-app-cms&pullRequest=28&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-app-cms] dependabot[bot] closed pull request #28: Bump engine.io and socket.io in /it
Posted by GitBox <gi...@apache.org>.
dependabot[bot] closed pull request #28: Bump engine.io and socket.io in /it
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org