You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/08 06:54:11 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #10481: [FLINK-14824][table] Improve schema derivation for formats

JingsongLi commented on a change in pull request #10481: [FLINK-14824][table] Improve schema derivation for formats
URL: https://github.com/apache/flink/pull/10481#discussion_r355163918
 
 

 ##########
 File path: docs/dev/table/connect.md
 ##########
 @@ -1321,12 +1322,12 @@ The CSV format can be used as follows:
 .withFormat(
   new Csv()
 
-    // required: define the schema either by using type information
-    .schema(Type.ROW(...))
-
-    // or use the table's schema
+    // optional: use the table's schema as format schema, this is enabled by default
     .deriveSchema()
 
 Review comment:
   Maybe we can remove it from doc now?
   Including `.deriveSchema()` and `.schema(Type.ROW(...))`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services