[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2051: [API-Draft] [Connector] Add Clickhouse source and sink connector

[GitBox <gi...@apache.org>]

CalvinKirs commented on code in PR #2051:
URL: https://github.com/apache/incubator-seatunnel/pull/2051#discussion_r906624064


##########
tools/dependencies/known-dependencies.txt:
##########
@@ -65,8 +65,11 @@ chill-java-0.9.3.jar
 chill_2.11-0.9.3.jar
 classmate-1.1.0.jar
 clickhouse-client-0.3.2-patch9.jar
+clickhouse-grpc-client-0.3.2-patch9-netty.jar
+clickhouse-http-client-0.3.2-patch9-shaded.jar
 clickhouse-http-client-0.3.2-patch9.jar
 clickhouse-jdbc-0.2.jar
+clickhouse-jdbc-0.3.2-patch9.jar

Review Comment:
   The licenses of these jars also need to be reflected in the LICENSE in dist



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org