You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hongtu Zang <ho...@tcloudcomputing.com> on 2013/04/24 06:20:29 UTC
Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network will
cause out of memory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/
-----------------------------------------------------------
Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
Description
-------
fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
This addresses bug CLOUDSTACK-2160.
Diffs
-----
server/src/com/cloud/network/NetworkModelImpl.java c5930d9
server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
Diff: https://reviews.apache.org/r/10750/diff/
Testing
-------
create a new network with netmask 255.0.0.0 and it won't cause out of memory
Thanks,
Hongtu Zang
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
Posted by Hongtu Zang <ho...@tcloudcomputing.com>.
> On May 6, 2013, 6:03 a.m., Prasanna Santhanam wrote:
> > Does this also fix CLOUDSTACK-1309?
No, I think it will not work in some issue.
If we have too much ips in a subnet(Class A or B), stack will check everyone and add free ips to a set. It will cause OOM when the set is too big.
So I changed it, the list has 255 members as most now.
But if we have several big wide subnet, and most ips in the subnet are already used, the stack will also check all ips to find out which are not used.
It won't cause OOM but it will take too long time also.
- Hongtu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20177
-----------------------------------------------------------
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20177
-----------------------------------------------------------
Does this also fix CLOUDSTACK-1309?
- Prasanna Santhanam
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20159
-----------------------------------------------------------
Commit 63f3ccd4dfc835581305bb57c0878861106dcfe6 in branch refs/heads/master from Pranav Saxena <pr...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=63f3ccd ]
CLOUDSTACK-2160:Refresh button functionality for security groups and statistics tab
- ASF Subversion and Git Services
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20048
-----------------------------------------------------------
Ship it!
Ship It!
- mice xia
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20171
-----------------------------------------------------------
Commit 63f3ccd4dfc835581305bb57c0878861106dcfe6 in branch refs/heads/vmware-datamodel from Pranav Saxena <pr...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=63f3ccd ]
CLOUDSTACK-2160:Refresh button functionality for security groups and statistics tab
- ASF Subversion and Git Services
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20049
-----------------------------------------------------------
Commit f1c794de1bb913002b5316992e331700a1f822b5 in branch refs/heads/master from Mice Xia <mi...@tcloudcomputing.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f1c794d ]
CLOUDSTACK-2160: fix bug add a huge size guest network will cause out of memory
Signed-off-by: Mice Xia <mi...@tcloudcomputing.com>
- ASF Subversion and Git Services
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>