You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/02/20 10:08:12 UTC
[GitHub] [airflow] eladkal opened a new pull request, #29633: `RedshiftDataOperator` replace `await_result` with `wait_for_completion`
eladkal opened a new pull request, #29633:
URL: https://github.com/apache/airflow/pull/29633
Followup of https://github.com/apache/airflow/pull/27947#discussion_r1096353052
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29633: `RedshiftDataOperator` replace `await_result` with `wait_for_completion`
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29633:
URL: https://github.com/apache/airflow/pull/29633#discussion_r1111744729
##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -73,10 +73,11 @@ def __init__(
secret_arn: str | None = None,
statement_name: str | None = None,
with_event: bool = False,
- await_result: bool = True,
+ await_result: bool | None = None,
poll_interval: int = 10,
aws_conn_id: str = "aws_default",
region: str | None = None,
+ wait_for_completion: bool = True,
Review Comment:
Small nit, could we move in `await_result` in the end of operator arguments? And in this place we could store `wait_for_completion`
This not affect to users because it is mandatory requirement for all operators to send arguments as key-value arguments and I think it would be nice to store all deprecated values in the bottom operator constructor definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #29633: `RedshiftDataOperator` replace `await_result` with `wait_for_completion`
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #29633:
URL: https://github.com/apache/airflow/pull/29633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org