[jira] [Commented] (METRON-1005) Create Decodable Row Key for Profiler

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086414#comment-16086414 ] 

ASF GitHub Bot commented on METRON-1005:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/622#discussion_r127329675
  
    --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java ---
    @@ -44,7 +46,17 @@
      * <li>group(s) - The group(s) used to sort the data in HBase. For example, a group may distinguish between weekends and weekdays.
      * <li>period - The period in which the measurement was taken. The first period starts at the epoch and increases monotonically.
      * </ul>
    + *
    + * This row key builder has no logic to decode a row key, nor is the row key generated by this builder
    + * easily decodable.  More specifically, the profile, entity, groups and period that make up the row key
    + * cannot be extracted from a previously generated row key.  This makes it difficult to answer questions
    + * like; What entities are included in this profile?  What is the period for this profile?  Use the
    + * DecodableRowKeyBuilder instead.
    + *
    + * @deprecated Replaced by DecodableRowKeyBuilder
    + * @see DecodableRowKeyBuilder
      */
    +@Deprecated
     public class SaltyRowKeyBuilder implements RowKeyBuilder {
    --- End diff --
    
    I marked the old `RowKeyBuilder` as deprecated.


> Create Decodable Row Key for Profiler
> -------------------------------------
>
>                 Key: METRON-1005
>                 URL: https://issues.apache.org/jira/browse/METRON-1005
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.3.0
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>             Fix For: Next + 1
>
>
> To be able to answer the types of questions that I outlined in METRON-450, we need a row key that is decodable.  Right now there is no logic to decode a row key, nor is the existing row key easily decodable.  
> Once the row keys can be decoded, you could scan all of the row keys in the Profiler's HBase table, decode each of them and extract things like, the names of all your profiles, the names of entities within a profile, the period duration of a given profile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)