You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/04/25 22:09:26 UTC

Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33554/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-2567
    https://issues.apache.org/jira/browse/MESOS-2567


Repository: mesos


Description
-------

Avoid Python declineOffer raise exception when filters is assigned to None explicitly


Diffs
-----

  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 

Diff: https://reviews.apache.org/r/33554/diff/


Testing
-------

make check


Thanks,

haosdent huang


Re: Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33554/#review81599
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33554]

All tests passed.

- Mesos ReviewBot


On April 25, 2015, 8:09 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33554/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 8:09 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2567
>     https://issues.apache.org/jira/browse/MESOS-2567
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoid Python declineOffer raise exception when filters is assigned to None explicitly
> 
> 
> Diffs
> -----
> 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 
> 
> Diff: https://reviews.apache.org/r/33554/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>