You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/26 14:38:47 UTC

[GitHub] [spark] srowen commented on pull request #37999: [SPARK-39146][CORE][SQL][K8S] Introduce `JacksonUtils` to use singleton Jackson ObjectMapper

srowen commented on PR #37999:
URL: https://github.com/apache/spark/pull/37999#issuecomment-1258141808

   My concern is that ObjectMapper, while thread-safe, is synchronized in some methods, IIRC. This could introduce contention for locks. Is the perf win really compelling? I wonder if we can reuse ObjectMapper inside classes where it matters for perf and not try to share one instance so widely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org