[GitHub] [druid] 317brian commented on a diff in pull request #12088: Clarify the use of the Lookup API

[GitBox <gi...@apache.org>]

317brian commented on code in PR #12088:
URL: https://github.com/apache/druid/pull/12088#discussion_r851558321


##########
docs/querying/lookups.md:
##########
@@ -290,6 +290,8 @@ For example, a post to `/druid/coordinator/v1/lookups/config/realtime_customer1/
 
 This will replace the `site_id_customer1` lookup in the `realtime_customer1` with the definition above.
 
+Make sure to assign a unique version identifier each time you update a lookup extractor factory. If the version already exists, the call will fail.

Review Comment:
   ```suggestion
   Make sure to assign a unique version identifier each time you update a lookup extractor factory. If the version already exists, the call falls.
   ```



##########
docs/querying/lookups.md:
##########
@@ -272,7 +272,7 @@ All entries in the map will UPDATE existing entries. No entries will be deleted.
 
 ### Update lookup
 
-A `POST` to a particular lookup extractor factory via `/druid/coordinator/v1/lookups/config/{tier}/{id}` will update that specific extractor factory.
+A `POST` to a particular lookup extractor factory via `/druid/coordinator/v1/lookups/config/{tier}/{id}` will create or update that specific extractor factory.

Review Comment:
   Really minor nit suggestions that replace future tense with present.



##########
docs/querying/lookups.md:
##########
@@ -272,7 +272,7 @@ All entries in the map will UPDATE existing entries. No entries will be deleted.
 
 ### Update lookup
 
-A `POST` to a particular lookup extractor factory via `/druid/coordinator/v1/lookups/config/{tier}/{id}` will update that specific extractor factory.
+A `POST` to a particular lookup extractor factory via `/druid/coordinator/v1/lookups/config/{tier}/{id}` will create or update that specific extractor factory.

Review Comment:
   ```suggestion
   A `POST` to a particular lookup extractor factory via `/druid/coordinator/v1/lookups/config/{tier}/{id}` creates or updates that specific extractor factory.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org