You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/08/05 09:27:52 UTC

[GitHub] [skywalking] wu-sheng commented on issue #3219: Log4j2 support AsyncRoot print tid

wu-sheng commented on issue #3219: Log4j2 support AsyncRoot print tid
URL: https://github.com/apache/skywalking/pull/3219#issuecomment-518158786
 
 
   1. If you are doing the same thing and covered the old cases, it is OK to delete the existing one.
   1. I noticed, there is no document update, is there any change about usage?
   1. The agent doesn't use log4j or any other log framework.
   1. Why do you comment `.or(nameStartsWith("org.apache.logging."))`? I don't think we are going to instrument log framework, do you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services