You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/10/10 00:03:48 UTC
Review Request: Adding default constructor for hashset
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7502/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Florian Leibert, and Ben Mahler.
Description
-------
See Summary
This addresses bug MESOS-288.
https://issues.apache.org/jira/browse/MESOS-288
Diffs
-----
third_party/libprocess/include/stout/hashset.hpp 958a93e93388a50c2b7476ce23a87eb2c99fa5e8
Diff: https://reviews.apache.org/r/7502/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Adding default constructor for hashset
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7502/#review12291
-----------------------------------------------------------
Piggybacking, could we do the same for hashmap.hpp? It will have the same problem if someone tries to create a const one.
- Ben Mahler
On Oct. 9, 2012, 10:03 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7502/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2012, 10:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Florian Leibert, and Ben Mahler.
>
>
> Description
> -------
>
> See Summary
>
>
> This addresses bug MESOS-288.
> https://issues.apache.org/jira/browse/MESOS-288
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/hashset.hpp 958a93e93388a50c2b7476ce23a87eb2c99fa5e8
>
> Diff: https://reviews.apache.org/r/7502/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Adding default constructor for hashset
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7502/#review12293
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 9, 2012, 10:29 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7502/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2012, 10:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary
>
>
> This addresses bug MESOS-288.
> https://issues.apache.org/jira/browse/MESOS-288
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/hashmap.hpp 620860b5afa2fb64ac144bd72aa3c9aae685127d
> third_party/libprocess/include/stout/hashset.hpp 958a93e93388a50c2b7476ce23a87eb2c99fa5e8
>
> Diff: https://reviews.apache.org/r/7502/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Adding default constructor for hashset
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7502/
-----------------------------------------------------------
(Updated Oct. 9, 2012, 10:29 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added a constructor for hashmap too.
Description
-------
See Summary
This addresses bug MESOS-288.
https://issues.apache.org/jira/browse/MESOS-288
Diffs (updated)
-----
third_party/libprocess/include/stout/hashmap.hpp 620860b5afa2fb64ac144bd72aa3c9aae685127d
third_party/libprocess/include/stout/hashset.hpp 958a93e93388a50c2b7476ce23a87eb2c99fa5e8
Diff: https://reviews.apache.org/r/7502/diff/
Testing
-------
make check
Thanks,
Vinod Kone