You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/09 16:34:04 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #18373: [improve][doc] Clarify maven running environments under windows

tisonkun commented on code in PR #18373:
URL: https://github.com/apache/pulsar/pull/18373#discussion_r1018167400


##########
README.md:
##########
@@ -137,8 +137,10 @@ components in the Pulsar ecosystem, including connectors, adapters, and other la
 - Maven 3.6.1+
 - zip
 
-> Note: this project includes a [Maven Wrapper](https://maven.apache.org/wrapper/) that can be used instead of a system installed Maven.
-> Use it by replacing `mvn` by `./mvnw` on Linux and `mvnw.cmd` on Windows in the commands below.
+> Notes:

Review Comment:
   ```suggestion
   > **Note**:
   ```
   
   Trying to make use of GitHub rendering like:
   
   <img width="581" alt="image" src="https://user-images.githubusercontent.com/18818196/200887060-c93197b8-38be-4a74-ba0b-4ff355c78f28.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org