You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/08 08:55:52 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
HuangXingBo opened a new pull request #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668
## What is the purpose of the change
*This pull request will support Python UDTF in old planner under batch mode*
## Brief change log
- *Add rules to convert RelNode to DataSetPythonCorrelate Node.*
- *Add PythonTableFunctionFlatMap function to invoke Python TableFunctions for the legacy planner*
## Verifying this change
This change added tests and can be verified as follows:
- *Added integration tests PyFlinkBatchUserDefinedTableFunctionTests in test_udtf.py*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159261199",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7655",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160718501",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d2e31fab3e7e023346cbec86fbb239c80310895 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160718501) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7655)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11668: [FLINK-17013][python]
Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610839657
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 48fe02ae72da140602cba512125240025d54d0c0 (Wed Apr 08 08:58:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17013).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159261199",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48fe02ae72da140602cba512125240025d54d0c0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159261199) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159261199",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48fe02ae72da140602cba512125240025d54d0c0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159261199) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208)
* 7d2e31fab3e7e023346cbec86fbb239c80310895 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#discussion_r409312243
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/plan/rules/batch/DataSetPythonCorrelateRule.java
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.rules.batch;
+
+import org.apache.flink.table.plan.nodes.FlinkConventions;
+import org.apache.flink.table.plan.nodes.dataset.DataSetPythonCorrelate;
+import org.apache.flink.table.plan.nodes.logical.FlinkLogicalCalc;
+import org.apache.flink.table.plan.nodes.logical.FlinkLogicalCorrelate;
+import org.apache.flink.table.plan.nodes.logical.FlinkLogicalTableFunctionScan;
+import org.apache.flink.table.plan.util.CorrelateUtil;
+import org.apache.flink.table.plan.util.PythonUtil;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelTraitSet;
+import org.apache.calcite.plan.volcano.RelSubset;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.convert.ConverterRule;
+import org.apache.calcite.rex.RexNode;
+
+import scala.Option;
+import scala.Some;
+
+/**
+ * The physical rule is responsible for convert {@link FlinkLogicalCorrelate} to
+ * {@link DataSetPythonCorrelate}.
+ */
+public class DataSetPythonCorrelateRule extends ConverterRule {
Review comment:
Maybe add some base classes for the two classes, i.e., `DataSetPythonCorrelateRule` and `DataStreamPythonCorrelateRule` to avoid the code duplications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159261199",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48fe02ae72da140602cba512125240025d54d0c0 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159261199) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159261199",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7655",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160718501",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d2e31fab3e7e023346cbec86fbb239c80310895 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160718501) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7655)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#discussion_r409297022
##########
File path: flink-python/pyflink/table/tests/test_udtf.py
##########
@@ -81,6 +81,42 @@ class PyFlinkBlinkStreamUserDefinedFunctionTests(UserDefinedTableFunctionTests,
pass
+class PyFlinkBatchUserDefinedTableFunctionTests(PyFlinkBatchTableTestCase):
+
+ def test_table_function(self):
Review comment:
I'm thinking to avoid these code duplications. Most parts of the code are the same, we only have to extract the different parts into methods and override the methods in the child classes. For example, we can add a base method named `get_output` in the `UserDefinedTableFunctionTests` and override the method in `PyFlinkBatchUserDefinedTableFunctionTests`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangXingBo commented on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-615202172
Thanks a lot for @hequn8128 review, I have addressed the comments at the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11668:
[FLINK-17013][python] Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159261199",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7655",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
}, {
"hash" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160718501",
"triggerID" : "7d2e31fab3e7e023346cbec86fbb239c80310895",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48fe02ae72da140602cba512125240025d54d0c0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159261199) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7208)
* 7d2e31fab3e7e023346cbec86fbb239c80310895 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160718501) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7655)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11668: [FLINK-17013][python]
Support Python UDTF in old planner under batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11668: [FLINK-17013][python] Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#issuecomment-610845431
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48fe02ae72da140602cba512125240025d54d0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "48fe02ae72da140602cba512125240025d54d0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48fe02ae72da140602cba512125240025d54d0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services