You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/11 11:16:34 UTC

[GitHub] [pulsar] gaoran10 opened a new pull request #10187: [WebSocket Client] WebSocket url token param value optimization

gaoran10 opened a new pull request #10187:
URL: https://github.com/apache/pulsar/pull/10187


   Fixes #10157 
   
   ### Modifications
   
   Remove the `Bearer ` prefix requirement for the token param value of the WebSocket url.
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Make the WebSocketHttpServletRequestWrapper return the right token value*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #10187: [WebSocket Client] WebSocket url token param value optimization

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10187:
URL: https://github.com/apache/pulsar/pull/10187


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on pull request #10187: [WebSocket Client] WebSocket url token param value optimization

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #10187:
URL: https://github.com/apache/pulsar/pull/10187#issuecomment-820456834


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #10187: [WebSocket Client] WebSocket url token param value optimization

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10187:
URL: https://github.com/apache/pulsar/pull/10187#issuecomment-819011281


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on pull request #10187: [WebSocket Client] WebSocket url token param value optimization

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #10187:
URL: https://github.com/apache/pulsar/pull/10187#issuecomment-819682639


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on pull request #10187: [WebSocket Client] WebSocket url token param value optimization

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #10187:
URL: https://github.com/apache/pulsar/pull/10187#issuecomment-817350278


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org