You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/26 15:55:20 UTC

[jira] [Work logged] (TS-4841) Log field cqtr is inaccurate for HTTP/2

     [ https://issues.apache.org/jira/browse/TS-4841?focusedWorklogId=29740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29740 ]

ASF GitHub Bot logged work on TS-4841:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Sep/16 15:55
            Start Date: 26/Sep/16 15:55
    Worklog Time Spent: 10m 
      Work Description: GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/1047

    TS-4841:  Log field cqtr is inaccurate for HTTP/2

    Fixed Http/2 get transaction count.  Added is_first_transaction_flag to Http2Stream to mark one of the streams as first.  Otherwise, by the time HttpSM logs the transaction, other streams are also likely to have gone through making the transaction count > 1, so no transaction would be logged as first.
    
    We have been running this patch internally and it seems to be more accurately logging first transactions on the stream.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-4841

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1047.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1047
    
----
commit 3f21fde41706c5c5ac41803521fe6b84aefc2758
Author: Susan Hinrichs <sh...@ieee.org>
Date:   2016-09-26T15:51:53Z

    TS-4841:  Log field cqtr is inaccurate for HTTP/2

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 29740)
            Time Spent: 10m
    Remaining Estimate: 0h

> Log field cqtr is inaccurate for HTTP/2
> ---------------------------------------
>
>                 Key: TS-4841
>                 URL: https://issues.apache.org/jira/browse/TS-4841
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2, Logging
>            Reporter: Susan Hinrichs
>             Fix For: 7.1.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> cqtr is supposed to log whether a transaction was executed over a previously opened TCP connection.  However, with HTTP/2, this field is created from the Http2ClientSession::get_transact_count() method.  This incorrectly returns the connection id which is constant for the session.  It should instead return the number of streams opened or something like that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)