[GitHub] [daffodil] mike-mcgann commented on a diff in pull request #981: Update parsing when emptyValueDelimiterPolicy is 'none'

["mike-mcgann (via GitHub)" <gi...@apache.org>]

mike-mcgann commented on code in PR #981:
URL: https://github.com/apache/daffodil/pull/981#discussion_r1129961689


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/LocalElementMixin.scala:
##########
@@ -84,6 +85,10 @@ trait LocalElementMixin extends ParticleMixin with LocalElementGrammarMixin {
       else if (
         isDefaultable && !hasTerminator && emptyValueDelimiterPolicy =:= EmptyValueDelimiterPolicy.Terminator
       ) true
+      else if (
+        hasInitiator && hasTerminator && emptyValueDelimiterPolicy =:= EmptyValueDelimiterPolicy.None

Review Comment:
   This was the only place in the code where I found something working with the emptyValueDelimiterPolicy directly. The negated value of this function gets set as "hasKnownRequiredSyntax" so I put this change in to see what would happen. This was to express the case that if there is both a initiator and a terminator but the policy is none, then it does not have a known required syntax. This change ended up having no effect and as I was tracing through the code, it didn't seem to be used in a way related to delimiter handling. I ended up looking elsewhere but forgot to remove this from the code. I just removed it and the tests still pass so it still had no effect. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org