[jira] [Created] (SPARK-8401) Build system scala version selection script requires version of sed which is not installed by default on Mac OS X

["Michael Allman (JIRA)" <ji...@apache.org>]

Michael Allman created SPARK-8401:
-------------------------------------

             Summary: Build system scala version selection script requires version of sed which is not installed by default on Mac OS X
                 Key: SPARK-8401
                 URL: https://issues.apache.org/jira/browse/SPARK-8401
             Project: Spark
          Issue Type: Bug
          Components: Build
    Affects Versions: 1.4.0
            Reporter: Michael Allman


The `dev/change-version-to-*.sh` selection scripts use syntax for GNU sed which produces incorrect results when run with Mac OS X's built in version of sed. For example:

```
[msa@Michaels-MacBook-Pro spark-1.4]$ ./dev/change-version-to-2.11.sh 
[msa@Michaels-MacBook-Pro spark-1.4]$ gst
On branch scala-versions
Your branch and 'vamp/scala-versions' have diverged,
and have 7 and 4 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   assembly/pom.xml
	modified:   bagel/pom.xml
	modified:   core/pom.xml
	modified:   dev/change-scala-version.sh
	modified:   docs/_plugins/copy_api_dirs.rb
	modified:   examples/pom.xml
	modified:   external/flume-sink/pom.xml
	modified:   external/flume/pom.xml
	modified:   external/kafka-assembly/pom.xml
	modified:   external/kafka/pom.xml
	modified:   external/mqtt/pom.xml
	modified:   external/twitter/pom.xml
	modified:   external/zeromq/pom.xml
	modified:   extras/java8-tests/pom.xml
	modified:   extras/kinesis-asl/pom.xml
	modified:   extras/spark-ganglia-lgpl/pom.xml
	modified:   graphx/pom.xml
	modified:   launcher/pom.xml
	modified:   mllib/pom.xml
	modified:   network/common/pom.xml
	modified:   network/shuffle/pom.xml
	modified:   network/yarn/pom.xml
	modified:   pom.xml
	modified:   repl/pom.xml
	modified:   sql/catalyst/pom.xml
	modified:   sql/core/pom.xml
	modified:   sql/hive-thriftserver/pom.xml
	modified:   sql/hive/pom.xml
	modified:   streaming/pom.xml
	modified:   tools/pom.xml
	modified:   unsafe/pom.xml
	modified:   yarn/pom.xml

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	assembly/pom.xml-e
	bagel/pom.xml-e
	core/pom.xml-e
	dev/audit-release/blank_maven_build/pom.xml-e
	dev/audit-release/maven_app_core/pom.xml-e
	docs/_plugins/copy_api_dirs.rb-e
	examples/pom.xml-e
	external/flume-sink/pom.xml-e
	external/flume/pom.xml-e
	external/kafka-assembly/pom.xml-e
	external/kafka/pom.xml-e
	external/mqtt/pom.xml-e
	external/twitter/pom.xml-e
	external/zeromq/pom.xml-e
        extras/java8-tests/pom.xml-e
	extras/kinesis-asl/pom.xml-e
	extras/spark-ganglia-lgpl/pom.xml-e
	graphx/pom.xml-e
	launcher/pom.xml-e
	mllib/pom.xml-e
	network/common/pom.xml-e
	network/shuffle/pom.xml-e
	network/yarn/pom.xml-e
	pom.xml-e
	repl/pom.xml-e
	sql/catalyst/pom.xml-e
	sql/core/pom.xml-e
	sql/hive-thriftserver/pom.xml-e
	sql/hive/pom.xml-e
	streaming/pom.xml-e
	tools/pom.xml-e
	unsafe/pom.xml-e
	yarn/pom.xml-e

no changes added to commit (use "git add" and/or "git commit -a")
```

Homebrew and MacPorts provide packages for GNU sed which install it as `gsed`. Therefore, I suggest that if the default system `sed` command is not GNU sed, we look for `gsed` and use it if available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org