You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 21:20:12 UTC

[GitHub] [airflow] vinooganesh opened a new pull request #21434: Task names should be consistent with variable names (drop vs create)

vinooganesh opened a new pull request #21434:
URL: https://github.com/apache/airflow/pull/21434


   The task names in the MySqlOperator docs currently are not consistent with the actual operations. This PR fixes that.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21434: Task names should be consistent with variable names (drop vs create)

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1044547949


   Rebased it as it seems that the errors were only "flaky". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21434: Task names should be consistent with variable names (drop vs create) in example dags

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1046047089


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vinooganesh commented on pull request #21434: Task names should be consistent with variable names (drop vs create)

Posted by GitBox <gi...@apache.org>.

vinooganesh commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1044717995


   @uranusjr @potiuk just fixed the static tests, had to force-push because I had some weirdness on my branch. Hope that's okay. If not, I can re-make the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21434: Task names should be consistent with variable names (drop vs create)

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1033072448

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vinooganesh commented on pull request #21434: Task names should be consistent with variable names (drop vs create)

Posted by GitBox <gi...@apache.org>.

vinooganesh commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1033291732


   @ashb - I see that you have reviewed similar changes from other folks. Could I please ask you to quickly look this over?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21434: Task names should be consistent with variable names (drop vs create)

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1044548396


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #21434: Task names should be consistent with variable names (drop vs create)

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1044684656


   Need to fix static checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal merged pull request #21434: Task names should be consistent with variable names (drop vs create) in example dags

Posted by GitBox <gi...@apache.org>.

eladkal merged pull request #21434:
URL: https://github.com/apache/airflow/pull/21434


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org