You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by iemejia <gi...@git.apache.org> on 2016/07/13 14:06:14 UTC
[GitHub] flink pull request #2240: [FLINK-4209] Docker image breaks with multiple NIC...
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2240
[FLINK-4209] Docker image breaks with multiple NICs
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iemejia/flink FLINK-4209
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2240
----
commit 1af7c871a1aa9d446436df96f4b1e2d9115aee34
Author: Isma�l Mej�a <ie...@gmail.com>
Date: 2016-07-05T02:16:07Z
[FLINK-4209] Change hostname resolution from IP to name
This solves issues when a host has multiple IPs
commit 385cb7f2ec2d629912b2a7af03f1ba1c76f49483
Author: Isma�l Mej�a <ie...@gmail.com>
Date: 2016-07-05T02:17:09Z
[FLINK-4209] Separate build dependencies in the docker image and remove them once it is ready
commit 88102e54fde4c967831ae1cc3e4025543e5fed57
Author: Isma�l Mej�a <ie...@gmail.com>
Date: 2016-07-05T07:23:46Z
[FLINK-4209] Add debug information of the build steps
commit b365fbd47db025dcf9d8d6d797ed7bdd85093b3f
Author: Isma�l Mej�a <ie...@gmail.com>
Date: 2016-07-11T15:23:17Z
[FLINK-4209] Simplify docker-compose script (volumes are now local)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
Yes, it is done, I am really happy of getting rid of python/supervisord in the image now.
Please merge if you consider it ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Docker image breaks with multiple NICs
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
I added some additional fixes for example to exclude build dependencies from the final image, and to make the docker-compose script simpler.
@aljoscha This is a set of small fixes that I missed at FLINK-4118.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2240
Would the Flink image be tied to a specific Flink version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
About the flink image version, we can support multiple versions via tags, those are pulled with the: separator, e.g. docker pull flink:1.0.3-hadoop26-scala_2.10
And we can agree on a default (e.g. most recent versions which would be -> :latest).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
@jagatfx Yes, this is still in my TODO list, I have not had a lot of time to follow the process to make an image official, but I hope I will in the next days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2240
@iemejia This is now good to merge?
From my side it looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2240: [FLINK-4209] Fix issue on docker with multiple NIC...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia closed the pull request at:
https://github.com/apache/flink/pull/2240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2240
I merged it. Could you please close this PR if it doesn't close automatically.
Thanks for the work! \U0001f603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2240
Yes, that would probably be good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
I added this last commit to remove the dependency on supervisord, thanks to @greghogan for the 'wait' idea. Now flink has the thinnest docker image possible :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2240
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by jagatfx <gi...@git.apache.org>.
Github user jagatfx commented on the issue:
https://github.com/apache/flink/pull/2240
@iemejia Were you able to followup on creating the official docker image. It's a great idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
One last thing, are you interested on getting the flink image into becoming an official docker image ? I took a look around it and it seems we can ask for this.
The benefit is that users can just make 'docker pull flink' and get the flink image from the hub.docker.com repository ready to use (e.g. I am publishing for the moment my own 'unofficial' builds at
https://hub.docker.com/r/iemejia/flink/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
Ok, I will check how is the procedure and I will tell you if we need something else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2240: [FLINK-4209] Fix issue on docker with multiple NICs and r...
Posted by iemejia <gi...@git.apache.org>.
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
Great, closing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---