You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/01 08:33:29 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4886: server: list routers by healthchecksfailed
ustcweizhou opened a new pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886
### Description
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r619186064
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@ustcweizhou what if "_router.health.checks.enabled_" config is disabled and there are last health check reports ? Will the routers listed with healthchecksfailed=trur returns empty list or routers with last failed reports or notifies health checks are not enabled?
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@ustcweizhou what if "_router.health.checks.enabled_" config is disabled and there are last health check reports ? Will the routers listed with healthchecksfailed=true returns empty list or routers with last failed reports or notifies health checks are not enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639463258
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@ustcweizhou if the results are out of date/incorrect when queried for, i think better to perform health checks and update the results. (Note: if it is a sync call, then it can take time, so just notify the operator that results are out of date and perform fresh health checks before listing routers by health checks failed). See if any time duration can be set (through API or global config) to validate the results are outside of that duration or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-848754855
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r645351586
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1343,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (isHealthCheckFailed != null) {
+ GenericSearchBuilder<RouterHealthCheckResultVO, Long> routerHealthCheckResultSearch = routerHealthCheckResultDao.createSearchBuilder(Long.class);
+ routerHealthCheckResultSearch.and("checkResult", routerHealthCheckResultSearch.entity().getCheckResult(), SearchCriteria.Op.EQ);
+ routerHealthCheckResultSearch.selectFields(routerHealthCheckResultSearch.entity().getRouterId());
+ routerHealthCheckResultSearch.done();
+ SearchCriteria<Long> ssc = routerHealthCheckResultSearch.create();
+ ssc.setParameters("checkResult", false);
+ routersWithFailures = routerHealthCheckResultDao.customSearch(ssc, null);
+
+ if (routersWithFailures != null && ! routersWithFailures.isEmpty()) {
+ if (isHealthCheckFailed) {
+ sb.and("routerId", sb.entity().getId(), SearchCriteria.Op.IN);
+ } else {
+ sb.and("routerId", sb.entity().getId(), SearchCriteria.Op.NIN);
+ }
+ } else if (isHealthCheckFailed) {
+ return new Pair<List<DomainRouterJoinVO>, Integer>(Collections.emptyList(), 0);
+ }
+ }
+
Review comment:
@weizhouapache can you put this in a separate procudure, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-848849458
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-848773382
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-848850258
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-847892771
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-847929515
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639706784
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@sureshanaparti yes. it is another story.
I removed the check on global setting "router.health.checks.enabled" in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-851409253
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-812514002
I like the functionality @weizhouapache , but by the look of the code there is still some wiring to do, is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-851432256
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-851455175
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639685281
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
> @sureshanaparti
> I think we need to make sure that the health check results are correct.
> if "router.health.checks.enabled" is changed from "true" to "false", we'd better remove all existing health check results as they will not be updated any more. btw: can we perform health check via api or ui when router.health.checks.enabled" is 'false" ?
@weizhouapache i think, the existing health check results are still there after changing "router.health.checks.enabled" from "true" to "false". May be this change can be checked in existing background thread and can cleanup the old health check results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-840375889
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-840372534
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-849313805
<b>Trillian test result (tid-751)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47100 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4886-t751-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 289.50 | test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 330.44 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 332.01 | test_routers_network_ops.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 523.65 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-851454773
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r645351586
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1343,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (isHealthCheckFailed != null) {
+ GenericSearchBuilder<RouterHealthCheckResultVO, Long> routerHealthCheckResultSearch = routerHealthCheckResultDao.createSearchBuilder(Long.class);
+ routerHealthCheckResultSearch.and("checkResult", routerHealthCheckResultSearch.entity().getCheckResult(), SearchCriteria.Op.EQ);
+ routerHealthCheckResultSearch.selectFields(routerHealthCheckResultSearch.entity().getRouterId());
+ routerHealthCheckResultSearch.done();
+ SearchCriteria<Long> ssc = routerHealthCheckResultSearch.create();
+ ssc.setParameters("checkResult", false);
+ routersWithFailures = routerHealthCheckResultDao.customSearch(ssc, null);
+
+ if (routersWithFailures != null && ! routersWithFailures.isEmpty()) {
+ if (isHealthCheckFailed) {
+ sb.and("routerId", sb.entity().getId(), SearchCriteria.Op.IN);
+ } else {
+ sb.and("routerId", sb.entity().getId(), SearchCriteria.Op.NIN);
+ }
+ } else if (isHealthCheckFailed) {
+ return new Pair<List<DomainRouterJoinVO>, Integer>(Collections.emptyList(), 0);
+ }
+ }
+
Review comment:
@weizhouapache can you put this in a separate procudure, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-851408681
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639132477
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@sureshanaparti if "router.health.checks.enabled" was "true" and then changed to "false", the health check results will be out of date and incorrect. In this case, do we need to consider the health check results ?
> @ustcweizhou what if "_router.health.checks.enabled_" config is disabled and there are last health check reports ? Will the routers listed with healthchecksfailed=true returns empty list or routers with last failed reports or notifies health checks are not enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-840372837
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-847893564
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r619186064
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@ustcweizhou what if "_router.health.checks.enabled_" config is disabled and there are last health check reports ? Will the routers listed with healthchecksfailed=trur returns empty list or notifies health checks not enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-848753955
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639498575
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1341,6 +1342,27 @@
sb.and("networkId", sb.entity().getNetworkId(), SearchCriteria.Op.EQ);
}
+ List<Long> routersWithFailures = null;
+ if (VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value() && isHealthCheckFailed != null) {
Review comment:
@sureshanaparti
I think we need to make sure that the health check results are correct.
if "router.health.checks.enabled" is changed from "true" to "false", we'd better remove all existing health check results as they will not be updated any more. btw: can we perform health check via api or ui when router.health.checks.enabled" is 'false" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4886:
URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-851699912
<b>Trillian test result (tid-795)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33418 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4886-t795-kvm-centos7.zip
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org