You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/18 01:01:27 UTC

[GitHub] [incubator-kyuubi] timothy65535 opened a new pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

timothy65535 opened a new pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   ### Description
   
   `ConfigBuilder` currently only supports public configuration by default. In practice, there are also some configurations, which are internal configurations and do not need to be reserved for users.
   
   refer to https://github.com/apache/incubator-kyuubi/pull/935#issuecomment-900117832
   
   ### Modification
   
   - Add `internal` to ConfigBuilder
   - Update `AllKyuubiConfiguration`
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] timothy65535 commented on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
timothy65535 commented on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900750393


   hi @ulysses-you 
   
   > Shall we skip generating configuration docs in AllKyuubiConfiguration if config tag is internal ?
   
   The internal optional is not exposed to end-user, so we don't need to update `settings.md`. We will never assign values manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] timothy65535 edited a comment on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
timothy65535 edited a comment on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900750393


   hi @ulysses-you 
   
   > Shall we skip generating configuration docs in AllKyuubiConfiguration if config tag is internal ?
   
   The internal optional is not exposed to end-user, so we don't need to update `settings.md`. We will never assign values manually.
   
   I had a quick flip through the spark project, internal options are not on the configuration list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#discussion_r690843722



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -119,6 +119,7 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
 
     KyuubiConf.kyuubiConfEntries.values().asScala
       .toSeq
+      .filterNot(_.internal)

Review comment:
       ah, I see thank you for the filter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900745385


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#949](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03107f7) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f21e118a4401b25281410894f104f15942326fb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f21e118) will **increase** coverage by `0.01%`.
   > The diff coverage is `90.00%`.
   
   > :exclamation: Current head 03107f7 differs from pull request most recent head 5d4723b. Consider uploading reports for the commit 5d4723b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #949      +/-   ##
   ============================================
   + Coverage     79.10%   79.12%   +0.01%     
     Complexity       11       11              
   ============================================
     Files           146      146              
     Lines          5414     5427      +13     
     Branches        654      654              
   ============================================
   + Hits           4283     4294      +11     
     Misses          757      757              
   - Partials        374      376       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...scala/org/apache/kyuubi/config/ConfigBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvQ29uZmlnQnVpbGRlci5zY2FsYQ==) | `93.50% <77.77%> (-2.33%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/config/ConfigEntry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvQ29uZmlnRW50cnkuc2NhbGE=) | `100.00% <100.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `44.62% <0.00%> (+0.82%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f21e118...5d4723b](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900744828


   Shall we skip generating configuration docs in `AllKyuubiConfiguration` if config tag is internal ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#discussion_r690843722



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -119,6 +119,7 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
 
     KyuubiConf.kyuubiConfEntries.values().asScala
       .toSeq
+      .filterNot(_.internal)

Review comment:
       ah, I see thank you for the filter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] timothy65535 commented on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
timothy65535 commented on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900750393


   hi @ulysses-you 
   
   > Shall we skip generating configuration docs in AllKyuubiConfiguration if config tag is internal ?
   
   The internal optional is not exposed to end-user, so we don't need to update `settings.md`. We will never assign values manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900745385


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#949](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03107f7) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f21e118a4401b25281410894f104f15942326fb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f21e118) will **increase** coverage by `0.01%`.
   > The diff coverage is `90.00%`.
   
   > :exclamation: Current head 03107f7 differs from pull request most recent head 5d4723b. Consider uploading reports for the commit 5d4723b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #949      +/-   ##
   ============================================
   + Coverage     79.10%   79.12%   +0.01%     
     Complexity       11       11              
   ============================================
     Files           146      146              
     Lines          5414     5427      +13     
     Branches        654      654              
   ============================================
   + Hits           4283     4294      +11     
     Misses          757      757              
   - Partials        374      376       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...scala/org/apache/kyuubi/config/ConfigBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvQ29uZmlnQnVpbGRlci5zY2FsYQ==) | `93.50% <77.77%> (-2.33%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/config/ConfigEntry.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvQ29uZmlnRW50cnkuc2NhbGE=) | `100.00% <100.00%> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `79.41% <0.00%> (-0.99%)` | :arrow_down: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/949/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `44.62% <0.00%> (+0.82%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f21e118...5d4723b](https://codecov.io/gh/apache/incubator-kyuubi/pull/949?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] timothy65535 edited a comment on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
timothy65535 edited a comment on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900750393


   hi @ulysses-you 
   
   > Shall we skip generating configuration docs in AllKyuubiConfiguration if config tag is internal ?
   
   The internal optional is not exposed to end-user, so we don't need to update `settings.md`. We will never assign values manually.
   
   I had a quick flip through the spark project, internal options are not on the configuration list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #949: [KYUUBI #942] Support for adding internal attributes to ConfigBuilder

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #949:
URL: https://github.com/apache/incubator-kyuubi/pull/949#issuecomment-900744828


   Shall we skip generating configuration docs in `AllKyuubiConfiguration` if config tag is internal ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org