You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ivandika3 (via GitHub)" <gi...@apache.org> on 2025/10/19 06:11:35 UTC
[PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
ivandika3 opened a new pull request, #9176:
URL: https://github.com/apache/ozone/pull/9176
## What changes were proposed in this pull request?
Backport notable bug fixes and improvements aimed for 1.4.2.
## How was this patch tested?
There is still some issues in some tests, notably `TestReplicationConfigPreference` which was backported in HDDS-10336. Tried to identify the root cause for a while (after updating the code to support the behavior of `GenericCli#setConfigurationOverrides` introduced in HDDS-11992), but unable to found the fix the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3525409030
@sarvekshayr @slfan1989 @will-sh @len548 @jianghuazhu @venkatsambath @hevinhsu Please kindly take a look at your respective commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3526703804
Thanks @ivandika3 for backporting!
I've checked 7938ac1, and compared with the original commit (d89c6ad), it seems to be missing the modification in
`hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v2/AbstractS3SDKV2Tests.java`.
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "sarvekshayr (via GitHub)" <gi...@apache.org>.
sarvekshayr commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3525434823
Thanks @ivandika3. I reviewed my commit - LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3526774516
Thanks @ivandika3 for the backport. I reviewed my commit - LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3527078868
> it seems to be missing the modification in
`hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v2/AbstractS3SDKV2Tests.java`
@hevinhsu Thanks a lot for highlighting this. I have added the missing tests. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "len548 (via GitHub)" <gi...@apache.org>.
len548 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3547819424
Reviewed [cd251f2](https://github.com/apache/ozone/commit/cd251f23a9f660ab514973b87668e00c9564faca), LGTM. Thanks for the update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3530387732
@devabhishekpal Thanks for checking.
> https://github.com/apache/ozone/commit/47993273232ea8e5a8eea06efd5ebe92f4ad4f84 looks good to me, however the jakarta annotation has been changed to javax annotation. Doesn't seem too big of a change but maybe we can check if this change is required
Jakarta annotation has not been widely used or imported in 1.4 branch. The javax to jakarta migration is addressed in HDDS-9905 which was aimed at 2.0.0. Since it's not a bug, we can use javax for 1.4. branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3514416369
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3525411417
Due to the high number of backported commits, I will merge this by this week if there are no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #9176:
URL: https://github.com/apache/ozone/pull/9176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "jianghuazhu (via GitHub)" <gi...@apache.org>.
jianghuazhu commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3546189382
LGTM.
Thanks @ivandika3 for the update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3565357368
Merged, thanks for all the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3530461690
> @hevinhsu Thanks a lot for highlighting this. I have added the missing tests. PTAL.
Thanks @ivandika3 for the update! I’ve reviewed the changes and everything LGTM now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] [DO NOT MERGE] Backport some commits to 1.4.2 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9176:
URL: https://github.com/apache/ozone/pull/9176#issuecomment-3526576421
Thanks @ivandika3 for the backport, these LGTM:
- 9b0e46a1b178a7d1e1d73b9545d8bd7132be8fed
- ea40b93a8b1dcc57b63b8429edef23ced6297ffc
- f1aae409a8da57224f070fc059392bbfc9a137b2
- 8ff85f973433905a2f4d0346ca6ced1d58f1dabb
- 709b90e1ec2b80ac8b9e8462df3a429f5ec276c8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org